Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-land PR #71840 (Rework MIR drop tree lowering) #77466

Merged
merged 10 commits into from
Oct 5, 2020
Merged

Re-land PR #71840 (Rework MIR drop tree lowering) #77466

merged 10 commits into from
Oct 5, 2020

Commits on Oct 4, 2020

  1. Defer creating drop trees in MIR lowering until leaving that scope

    @matthewjasper @Aaron1011
    matthewjasper authored and Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    fa3e2fc View commit details
    Browse the repository at this point in the history

  2. Reduce the number of drop-flag assignments in unwind paths

    @matthewjasper @Aaron1011
    matthewjasper authored and Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    f810e60 View commit details
    Browse the repository at this point in the history

  3. Add some more comments

    @matthewjasper @Aaron1011
    matthewjasper authored and Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    1e71862 View commit details
    Browse the repository at this point in the history

  4. Address review comments

    @matthewjasper @Aaron1011
    matthewjasper authored and Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    8902ce5 View commit details
    Browse the repository at this point in the history

  5. Fix rebase fallout

    @Aaron1011
    Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    4c83eec View commit details
    Browse the repository at this point in the history

  6. Add regression test for issue rust-lang#72470 

    This was fixed with the upgrade to LLVM 11 in rust-lang#73526.
It seems extremely unlikey that this exact issue will ever reoccur,
since slight modifications to the code caused the crash to stop
happening. However, it can't hurt to have a test for it.
    @Aaron1011
    Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    f23e9a1 View commit details
    Browse the repository at this point in the history

  7. Fix broken link

    @Aaron1011
    Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    8478385 View commit details
    Browse the repository at this point in the history

  8. Bless mir-opt tests

    @Aaron1011
    Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    33337bb View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from review 

    Co-authored-by: matthewjasper <20113453+matthewjasper@users.noreply.github.com>
    @Aaron1011 @matthewjasper
    Aaron1011 and matthewjasper committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    eb94cdd View commit details
    Browse the repository at this point in the history

  10. Bless more test output

    @Aaron1011
    Aaron1011 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    ce8d757 View commit details
    Browse the repository at this point in the history