Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some inference-related regression tests about incorrect diagnostics #78265

Merged
merged 2 commits into from
Oct 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/test/ui/inference/issue-71732.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Regression test for #71732, it used to emit incorrect diagnostics, like:
// error[E0283]: type annotations needed
// --> src/main.rs:5:10
// |
// 5 | .get(&"key".into())
// | ^^^ cannot infer type for struct `String`
// |
// = note: cannot satisfy `String: Borrow<_>`
// help: consider specifying the type argument in the method call
// |
// 5 | .get::<Q>(&"key".into())
// |

use std::collections::hash_map::HashMap;

fn foo(parameters: &HashMap<String, String>) -> bool {
parameters
.get(&"key".into()) //~ ERROR: type annotations needed
.and_then(|found: &String| Some(false))
.unwrap_or(false)
}

fn main() {}
13 changes: 13 additions & 0 deletions src/test/ui/inference/issue-71732.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
error[E0283]: type annotations needed
--> $DIR/issue-71732.rs:18:10
|
LL | .get(&"key".into())
| ^^^ ------------ this method call resolves to `T`
| |
| cannot infer type for type parameter `Q` declared on the associated function `get`
|
= note: cannot satisfy `String: Borrow<_>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.
29 changes: 29 additions & 0 deletions src/test/ui/inference/issue-72616.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Regression test for #72616, it used to emit incorrect diagnostics, like:
// error[E0283]: type annotations needed for `String`
// --> src/main.rs:8:30
// |
// 5 | let _: String = "".to_owned().try_into().unwrap();
// | - consider giving this pattern a type
// ...
// 8 | if String::from("a") == "a".try_into().unwrap() {}
// | ^^ cannot infer type for struct `String`
// |
// = note: cannot satisfy `String: PartialEq<_>`

use std::convert::TryInto;

pub fn main() {
{
let _: String = "".to_owned().try_into().unwrap();
}
{
if String::from("a") == "a".try_into().unwrap() {}
//~^ ERROR: type annotations needed
}
{
let _: String = match "_".try_into() {
Ok(a) => a,
Err(_) => "".into(),
};
}
}
13 changes: 13 additions & 0 deletions src/test/ui/inference/issue-72616.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
error[E0283]: type annotations needed
--> $DIR/issue-72616.rs:20:30
|
LL | if String::from("a") == "a".try_into().unwrap() {}
| ^^ -------------- this method call resolves to `std::result::Result<T, <Self as TryInto<T>>::Error>`
| |
| cannot infer type
|
= note: cannot satisfy `String: PartialEq<_>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.