Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make codegen coverage_context optional, and check #78300

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Make codegen coverage_context optional, and check #78300

merged 2 commits into from
Oct 24, 2020

Commits on Oct 23, 2020

  1. Make codegen coverage_context optional, and check 

    Addresses Issue rust-lang#78286

Libraries compiled with coverage and linked with out enabling coverage
would fail when attempting to add the library's coverage statements to
the codegen coverage context (None).

Now, if coverage statements are encountered while compiling / linking
with `-Z instrument-coverage` disabled, codegen will *not* attempt to
add code regions to a coverage map, and it will not inject the LLVM
instrprof_increment intrinsic calls.
    @richkadel
    richkadel committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a7bc1a2 View commit details
    Browse the repository at this point in the history

  2. Update compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs 

    Co-authored-by: Wesley Wiser <wwiser@gmail.com>
    @richkadel @wesleywiser
    richkadel and wesleywiser committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    f75a236 View commit details
    Browse the repository at this point in the history