Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FIXME comment in some incremental test suite #78670

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Nov 2, 2020

Helps with #62277

I removed FIXME comment in some incremental tests with rustc_partition_codegened. This seems using codegen process. So it uses intentionally build-pass

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 4, 2020

Could you explain briefly why these should be check-pass instead of build-pass? #62277 (comment)

Especially for incremental, I'd be worried this isn't actually testing everything it should be.

@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Nov 4, 2020
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2020
@sasurau4 sasurau4 changed the title Use check-pass or build-pass in incremental test suite Remove FIXME comment in some incremental test suite Nov 20, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 21, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 21, 2020

📌 Commit f02296a has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2020
@bors
Copy link
Contributor

bors commented Nov 22, 2020

⌛ Testing commit f02296a with merge 64f8d36d387ec10b8d9b02316abfeeea719493f9...

@bors
Copy link
Contributor

bors commented Nov 22, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 22, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 22, 2020

warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/quote/0.3.15/download`, got 504
warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/quote/0.3.15/download`, got 504
error: failed to download from `https://crates.io/api/v1/crates/quote/0.3.15/download`

Caused by:
  failed to get 200 response from `https://crates.io/api/v1/crates/quote/0.3.15/download`, got 504
thread 'main' panicked at 'tests failed for https://github.com/BurntSushi/xsv', src\tools\cargotest\main.rs:72:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@bors
Copy link
Contributor

bors commented Nov 22, 2020

⌛ Testing commit f02296a with merge ae50593152d8e9a6ebd1de79afb65a5754c113df...

@bors
Copy link
Contributor

bors commented Nov 22, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 22, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 22, 2020

Run src/ci/scripts/install-clang.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0  516M    0 3167k    0     0  17.2M      0  0:00:29 --:--:--  0:00:29 17.2M
  5  516M    5 30.8M    0     0  25.1M      0  0:00:20  0:00:01  0:00:19 25.1M
 11  516M   11 57.4M    0     0  25.6M      0  0:00:20  0:00:02  0:00:18 25.6M
 16  516M   16 83.9M    0     0  25.9M      0  0:00:19  0:00:03  0:00:16 25.9M
 21  516M   21  109M    0     0  26.1M      0  0:00:19  0:00:04  0:00:15 26.1M
 26  516M   26  136M    0     0  26.2M      0  0:00:19  0:00:05  0:00:14 26.6M
 31  516M   31  162M    0     0  26.1M      0  0:00:19  0:00:06  0:00:13 26.4M
 36  516M   36  189M    0     0  26.4M      0  0:00:19  0:00:07  0:00:12 26.7M
 41  516M   41  216M    0     0  26.4M      0  0:00:19  0:00:08  0:00:11 26.7M
 42  516M   42  221M    0     0  26.2M      0  0:00:19  0:00:08  0:00:11 26.4M
curl: (56) OpenSSL SSL_read: Connection was reset, errno 10054

@bors retry

cc @rust-lang/infra - is there anything we can do to make the network dependencies more reliable? Maybe we could cache the downloads in a docker container so we just have to download that?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2020
…laumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#78670 (Remove FIXME comment in some incremental test suite)
 - rust-lang#79292 (Fix typo in doc comment for report_too_many_hashes)
 - rust-lang#79300 (Prevent feature information to be hidden if it's on the impl directly)
 - rust-lang#79302 (Add regression test for issue 73899)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 876024d into rust-lang:master Nov 22, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 22, 2020
@sasurau4 sasurau4 deleted the test/check-pass-incremental branch November 24, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants