Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-2229: Implement Precise Capture Analysis #78801

Merged
merged 16 commits into from
Nov 17, 2020
Merged

RFC-2229: Implement Precise Capture Analysis #78801

merged 16 commits into from
Nov 17, 2020

Commits on Nov 11, 2020

  1. Use Places to express closure/generator Captures 

    Co-authored-by: Archer Zhang <archer.xn@gmail.com>
    @arora-aman @Azhng
    arora-aman and Azhng committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    127a6ed View commit details
    Browse the repository at this point in the history

  2. Indroduce feature flag for RFC-2229 

    Signed-off-by: Aman Arora <me@aman-arora.com>
    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    88310cc View commit details
    Browse the repository at this point in the history

  3. Add initial set of testcases for RFC 2229 

    Co-authored-by: Dhruv Jauhar <dhruvjhr@gmail.com>
    @arora-aman @null-sleep
    arora-aman and null-sleep committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    58e8f8f View commit details
    Browse the repository at this point in the history

  4. Add helper function for Capture Esclations and expressions 

    Co-authored-by: Dhruv Jauhar <dhruvjhr@gmail.com>
    @arora-aman @null-sleep
    arora-aman and null-sleep committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1453120 View commit details
    Browse the repository at this point in the history

  5. Initial work for doing minimum capture analysis for RFC-2229 

    Co-authored-by: Chris Pardy <chrispardy36@gmail.com>
Co-authored-by: Logan Mosier <logmosier@gmail.com>
    @arora-aman @ChrisPardy @logmosier
    3 people committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    8f0c0d6 View commit details
    Browse the repository at this point in the history

  6. Update tests with min capture information 

    Co-authored-by: Chris Pardy <chrispardy36@gmail.com>
Co-authored-by: Logan Mosier <logmosier@gmail.com>
    @arora-aman @ChrisPardy @logmosier
    3 people committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    b16815b View commit details
    Browse the repository at this point in the history

  7. Reduce verbosity of capture analysis logs 

    Co-authored-by: Jenny Wills <wills.jenniferg@gmail.com>
Co-authored-by: Aman Arora <me@aman-arora.com>
    @roxelo @jenniferwills @arora-aman
    3 people committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    825e9e4 View commit details
    Browse the repository at this point in the history

  8. Handle let _ = x patterns in closure liveness analysis

    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    fa38160 View commit details
    Browse the repository at this point in the history

  9. More pattern testcases

    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    be77402 View commit details
    Browse the repository at this point in the history

  10. Remove local testing env var

    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    abc4004 View commit details
    Browse the repository at this point in the history

  11. Address review comments

    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    43423f6 View commit details
    Browse the repository at this point in the history

  12. Address review comments 2

    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    deeb025 View commit details
    Browse the repository at this point in the history

  13. Add test for capturing enums

    @arora-aman
    arora-aman committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    d0fac05 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Log closure as well

    @arora-aman
    arora-aman committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c50e57f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2020

  1. Fix case when ExprUseVisitor is called after typeck writeback 

    Clippy uses `ExprUseVisitor` and atleast in some cases it runs
after writeback.

We currently don't writeback the min_capture results of closure
capture analysis since no place within the compiler itself uses it.

In the short term to fix clippy we add a fallback when walking captures
of a closure to check if closure_capture analysis has any entries in it.

Writeback for closure_min_captures will be implemented in
rust-lang/project-rfc-2229#18
    @arora-aman
    arora-aman committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    bb8c5e5 View commit details
    Browse the repository at this point in the history

  2. Ignore doctest for capture analysis examples

    @arora-aman
    arora-aman committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    40dfe1e View commit details
    Browse the repository at this point in the history