Improve the page title switch handling between search and doc #78921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
pickfire
reviewed
Nov 10, 2020
| @@ -113,6 +113,7 @@ function defocusSearchBar() { | |||
| var mouseMovedAfterSearch = true; | |||
|
|
|||
| var titleBeforeSearch = document.title; | |||
| var searchTitle = null; | |||
There was a problem hiding this comment.
Do we really need another variable? Why not just directly modify document.title?
There was a problem hiding this comment.
We do, but it's simpler in case we come back to the search instead of regenerate it once again.
jyn514
added
A-rustdoc-ui
jyn514
reviewed
Nov 10, 2020
| @@ -2736,6 +2738,7 @@ function defocusSearchBar() { | |||
| "", | |||
| "?search=" + encodeURIComponent(search_input.value)); | |||
| } | |||
| document.title = searchTitle; | |||
There was a problem hiding this comment.
When does putBackSearch run? Are you sure search() will be run before?
There was a problem hiding this comment.
putBackSearch is run when you focus the search input and it's not empty. Meaning that the search already ran at this point. ;)
|
@bors r+ rollup |
|
📌 Commit 46c921d has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2020
… r=jyn514 Improve the page title switch handling between search and doc The current behavior often "forgets" to update the page title when discarding/putting back the search results. This isn't optimal which is why I wrote this fix. r? `@jyn514`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2020
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#78916 (extend const generics test suite) - rust-lang#78921 (Improve the page title switch handling between search and doc) - rust-lang#78933 (Don't print thread ids and names in `tracing` logs) - rust-lang#78960 (Test default values for const parameters.) - rust-lang#78971 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior often "forgets" to update the page title when discarding/putting back the search results. This isn't optimal which is why I wrote this fix.
r? @jyn514