Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bootstrap compiler version #79219

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Bump bootstrap compiler version #79219

merged 1 commit into from
Nov 22, 2020

Conversation

shepmaster
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2020
@shepmaster
Copy link
Member Author

shepmaster commented Nov 19, 2020 •
edited
Loading

This passed a ../x.py build on x86_64-apple-darwin and ../x.py build --stage=2 on aarch64-apple-darwin.

@jyn514
Copy link
Member

jyn514 commented Nov 19, 2020 

  = note: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/std-eb1773117794feb5.1tji65w091gq2h3n.rcgu.o: In function `__rust_alloc_error_handler':
          1tji65w091gq2h3n:(.text.__rust_alloc_error_handler+0x1): undefined reference to `__rg_oom'
          /usr/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libstd-eb1773117794feb5.so: hidden symbol `__rg_oom' isn't defined
          /usr/bin/ld: final link failed: Bad value
          collect2: error: ld returned 1 exit status
          

error: aborting due to previous error

error: could not compile `std`

@shepmaster
Copy link
Member Author

shepmaster commented Nov 20, 2020 •
edited
Loading

Hmm, probably important to look for all the cfg(bootstrap), not just the ones that caused me an error.

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 20, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Nov 22, 2020

📌 Commit dcef5ff has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@bors
Copy link
Contributor

bors commented Nov 22, 2020

⌛ Testing commit dcef5ff with merge a0d664b...

@bors
Copy link
Contributor

bors commented Nov 22, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing a0d664b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2020
@bors bors merged commit a0d664b into rust-lang:master Nov 22, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 22, 2020
@bors bors mentioned this pull request Nov 23, 2020
Merged
@shepmaster shepmaster deleted the beta-bump branch November 23, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shepmaster @jyn514 @Mark-Simulacrum @bors @rust-highfive @rustbot