Rollup of 11 pull requests #79529
Merged
Rollup of 11 pull requests #79529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors when compiling rust programs
"simple type inference fails depending on order of trait bounds"
…, r=Mark-Simulacrum Require allocator to be static for boxed `Pin`-API Allocators has to retain their validity until the instance and all of its clones are dropped. When pinning a value, it must live forever, thus, the allocator requires a `'static` lifetime for pinning a value. [Example from reddit](https://www.reddit.com/r/rust/comments/jymzdw/the_story_continues_vec_now_supports_custom/gd7qak2?utm_source=share&utm_medium=web2x&context=3): ```rust let alloc = MyAlloc(/* ... */); let pinned = Box::pin_in(42, alloc); mem::forget(pinned); // Now `value` must live forever // Otherwise `Pin`'s invariants are violated, storage invalidated // before Drop was called. // borrow of `memory` can end here, there is no value keeping it. drop(alloc); // Oh, value doesn't live forever. ```
…jyn514 Rename "stability" CSS class to "item-info" and combine `document_stability` with `document_short` Follow-up of rust-lang#79300 The point of this PR is to make the CSS class more accurate since it's not only about stability anymore. r? ``@jyn514``
…ark-Simulacrum BTreeMap: try to enhance various comments All in internal documentation, propagating the "key-value pair" notation from public documentation. r? ``@Mark-Simulacrum``
Move ui if tests from top-level into `expr/if` This lowers the number of top-level files in src/test/ui from 1612 to 1604.
…rror-output, r=jyn514
Improve rustdoc JS tests error output
It's pretty common when starting to add new tests for rustdoc-js to have issues to understand the errors. With this, it should make things a bit simpler. So now, in case of an error, it displays:
```
---- [js-doc-test] rustdoc-js/basic.rs stdout ----
error: rustdoc-js test failed!
failed to decode compiler output as json: line: {
output: Checking "basic" ... FAILED
==> Result not found in 'others': '{"path":"basic","name":"Fo"}'
Diff of first error:
{
"path": "basic",
- "name": "Fo",
+ "name": "Foo",
}
thread '[js-doc-test] rustdoc-js/basic.rs' panicked at 'explicit panic', src/tools/compiletest/src/json.rs:126:21
```
I think it was ``@camelid`` who asked about it a few days ago?
r? ``@jyn514``
…=jyn514 Extend doc keyword feature by allowing any ident Part of rust-lang#51315. As suggested by ``@danielhenrymantilla`` in [this comment](rust-lang#51315 (comment)), this PR extends `#[doc(keyword = "...")]` to allow any ident to be used as keyword. The final goal is to allow (proc-)macro crates' owners to write documentation of the keywords they might introduce. r? ``@jyn514``
add enable-full-tools to freebsd builds to prevent occasional link er… On FreeBSD, there is sometimes an issue where linking a rust program will fail due to rust not finding a linker, even though lld is included in the base system. This seems to mostly affect bare metal/cross compilation things, such as wasm builds and arm/riscv bare metal work (eg. when trying to compile [this](https://github.com/quantumscraps/scraps)). On Linux and other operating systems, full tools are enabled for builds of rust, so there are no linking issues. This pr should enable fully functional builds on FreeBSD, assuming rust builds correctly with these options.
Cleanup: shorter and faster code
…t-bounds, r=Mark-Simulacrum Add test for issue rust-lang#54121: order dependent trait bounds This adds a test for rust-lang#54121, which has already been fixed by rust-lang#73905. Now that issue can be closed. I tested the test [on the playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6cb061d3b81518f268649551eb67769f) where it indeed fails on stable 1.48, but compiles successfully on beta and nightly. fixes rust-lang#54121
…n1011 Remove unnecessary `mut` binding Found while fiddling around with rust-lang#77459.
Fix a bootstrap comment
|
@bors r+ rollup=never p=5 |
|
📌 Commit d0515ce has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Pin-API #79327 (Require allocator to be static for boxedPin-API)document_stabilitywithdocument_short#79340 (Rename "stability" CSS class to "item-info" and combinedocument_stabilitywithdocument_short)expr/if#79395 (Move ui if tests from top-level intoexpr/if)mutbinding #79516 (Remove unnecessarymutbinding)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup