Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't time emit_ignored_resolution_errors #79575

Merged
merged 1 commit into from Dec 9, 2020
Merged

Don't time emit_ignored_resolution_errors #79575

merged 1 commit into from Dec 9, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 30, 2020

This printed several hundred lines each time rustdoc was run, almost all
of which rounded to 0.000. Since this isn't useful info, don't print it
everywhere, so other perf info is easier to read.

r? @Mark-Simulacrum

@jyn514
Don't time emit_ignored_resolution_errors
db7373d 
This printed several hundred lines each time rustdoc was run, almost all
of which rounded to 0.000. Since this isn't useful info, don't print it
everywhere, so other perf info is easier to read.
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-compiler-performance Working group: Compiler Performance A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Nov 30, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 8, 2020

📌 Commit db7373d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2020
@bors
Copy link
Contributor

bors commented Dec 9, 2020

⌛ Testing commit db7373d with merge 8080f54...

@bors
Copy link
Contributor

bors commented Dec 9, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8080f54 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2020
@bors bors merged commit 8080f54 into rust-lang:master Dec 9, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 9, 2020
@jyn514 jyn514 deleted the time-passes branch December 9, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-compiler-performance Working group: Compiler Performance
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jyn514 @Mark-Simulacrum @bors @rust-highfive @rustbot