Don't look for blanket impls in intra-doc links #79682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-rustdoc
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
jyn514
force-pushed
the
no-blanket-impls
branch
from
1ac6c26
to
b388a9b
Compare
jyn514
commented
Dec 4, 2020
jyn514
added
the
I-compiletime
|
I'm testing locally that this actually improves the compile times for #78761. |
jyn514
force-pushed
the
no-blanket-impls
branch
from
b388a9b
to
41ef900
Compare
|
Yup, this brought intra-doc links down to only 1.5 seconds 🎉 (down from 90 seconds). |
GuillaumeGomez
approved these changes
Dec 11, 2020
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
no-blanket-impls
branch
from
9917b2a
to
667f6d5
Compare
|
☔ The latest upstream changes (presumably #80044) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
jyn514
force-pushed
the
no-blanket-impls
branch
from
667f6d5
to
e75c637
Compare
This never worked and has been causing severe performance problems. Hopefully it will be re-landed at some point in the future when it actually works, but in the meantime it makes no sense to have the code around when it does nothing and actively makes rustdoc harder to use.
jyn514
force-pushed
the
no-blanket-impls
branch
from
e75c637
to
6580f11
Compare
|
@bors r=Manishearth,GuillaumeGomez |
|
📌 Commit 6580f11 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
jyn514
added
the
relnotes-perf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never worked and has been causing severe performance problems.
Hopefully it will be re-landed at some point in the future when it
actually works, but in the meantime it makes no sense to have the code
around when it does nothing and actively makes rustdoc harder to use.
Closes #78761. Does not affect #78800.
r? @Manishearth
cc @seeplusplus