Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stdarch submodule #79938

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Update stdarch submodule #79938

merged 1 commit into from
Dec 15, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Dec 11, 2020

Changes included:

  • Use a bootstrap guard for modules with new target features
  • Avoid calling intrinsics with invalid const arguments
  • Avx512bw
  • Avx512cd
  • Add AVX512BITALG
  • Add GFNI Intrinsics
  • Add AVX512VPOPCNTDQ Intrinsics
  • Add VPCLMULQDQ Intrinsics
  • Avx512bw
  • Reimplement _xgetbv with LLVM intrinsics
  • Avx512bw
  • Add reamained vmax and vmin via auto-generated code
  • Add VAES intrinsics

Fixes #56483.

@tmiasko
Copy link
Contributor Author

tmiasko commented Dec 11, 2020

@bors rollup=never (due to potential impact on build times).

r? @Amanieu

@bors
Copy link
Contributor

bors commented Dec 11, 2020

@tmiasko: 🔑 Insufficient privileges: not in try users

@Amanieu
Copy link
Member

Amanieu commented Dec 11, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Dec 11, 2020

📌 Commit 5ba7e99 has been approved by Amanieu

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 11, 2020
@bors
Copy link
Contributor

bors commented Dec 12, 2020

⌛ Testing commit 5ba7e99 with merge 0cc990783371f7102893a9b00a2a56e951d35f19...

@bors
Copy link
Contributor

bors commented Dec 12, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2020
@Amanieu
Copy link
Member

Amanieu commented Dec 12, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#79938 - tmiasko:stdarch, r=Amanieu
90da048 
Update stdarch submodule

Changes included:

* Use a bootstrap guard for modules with new target features
* Avoid calling intrinsics with invalid const arguments
* Avx512bw
* Avx512cd
* Add AVX512BITALG
* Add GFNI Intrinsics
* Add AVX512VPOPCNTDQ Intrinsics
* Add VPCLMULQDQ Intrinsics
* Avx512bw
* Reimplement `_xgetbv` with LLVM intrinsics
* Avx512bw
* Add reamained vmax and vmin via auto-generated code
* Add VAES intrinsics

Fixes rust-lang#56483.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 12, 2020
Closed
@bors
Copy link
Contributor

bors commented Dec 13, 2020

⌛ Testing commit 5ba7e99 with merge 4a8ae56dc22c6660f2109aaf62ef0c31e1ecfca8...

@bors
Copy link
Contributor

bors commented Dec 13, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2020
@tmiasko
Copy link
Contributor Author

tmiasko commented Dec 14, 2020

Spurious failure:

LINK : fatal error LNK1201: error writing to program database 'D:\a\rust\rust\build\i686-pc-windows-msvc\test\run-make-fulldeps\override-aliased-flags\override-aliased-flags\main.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

@Amanieu
Copy link
Member

Amanieu commented Dec 14, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2020
@bors
Copy link
Contributor

bors commented Dec 14, 2020

⌛ Testing commit 5ba7e99 with merge 8b3ee82...

@bors
Copy link
Contributor

bors commented Dec 15, 2020

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 8b3ee82 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2020
@bors bors merged commit 8b3ee82 into rust-lang:master Dec 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 15, 2020
@tmiasko tmiasko deleted the stdarch branch December 15, 2020 00:49
@rylev
Copy link
Member

rylev commented Dec 15, 2020 •
edited
Loading

@tmiasko @Amanieu This change caused [lots of regressions in the perf benchmark. We should look into this to see if we can win some of the performance losses back. Most the perf losses seem to be in doc builds.

@camelid camelid mentioned this pull request Dec 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

LLVM assertion in simdnoise crate
5 participants
@tmiasko @bors @Amanieu @rylev @rustbot