update rustfmt to v1.4.30

[calebcartwright]

Contains fixes for a few reported bugs on current nightly (1.4.29)

Notes in: https://github.com/rust-lang/rustfmt/releases/tag/v1.4.30

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[rust-log-analyzer]

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

######################################################################## 100.0%
extracting /checkout/obj/build/cache/2020-11-19/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/rustfmt`
error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
make: *** [prepare] Error 1
Makefile:60: recipe for target 'prepare' failed
Command failed. Attempt 2/5:
    Updating crates.io index
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/rustfmt`
error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
make: *** [prepare] Error 1
Makefile:60: recipe for target 'prepare' failed
Command failed. Attempt 3/5:
    Updating crates.io index
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/rustfmt`
error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
make: *** [prepare] Error 1
Makefile:60: recipe for target 'prepare' failed
Command failed. Attempt 4/5:
    Updating crates.io index
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/rustfmt`
error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
make: *** [prepare] Error 1
Makefile:60: recipe for target 'prepare' failed
Command failed. Attempt 5/5:
    Updating crates.io index
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/rustfmt`
error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
make: *** [prepare] Error 1
Makefile:60: recipe for target 'prepare' failed
The command has failed after 5 attempts.

[Mark-Simulacrum]

@bors r+ rollup=iffy

Note that we're in beta week.

[bors]

📌 Commit 8cfaf94 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 8cfaf94 with merge c610895b5447f208eb0ffe36dcbcfabd1887eb9c...

[calebcartwright]

Note that we're in beta week.

I have to confess I don't fully understand the implications of this.

It looks like v1.4.25 of rustfmt is currently in beta so that should be fine, but a couple questions for my own edification:

• any docs/material around the release process, at least as it relates to tools, that you'd recommend reading so that i can get more familiar?
• is my understanding correct that whatever version of tools' submods is on the beta branch in this repo is what's currently in beta and thus slated for the next upcoming release?

[Mark-Simulacrum]

We'll branch the next beta from master on Friday, and tools can't regress their state over the next 5 (IIRC) days so that the branched beta has all tools passing.

With regards to release of 1.49 in ~2 weeks, yes, that should be the current beta branch set of tools.

[calebcartwright]

We'll branch the next beta from master on Friday, and tools can't regress their state over the next 5 (IIRC) days so that the branched beta has all tools passing.

So if this gets merged before Friday then we'd be able to get this version into the next beta instead of the current 1.4.29 (which has a couple known bugs), correct?

[Mark-Simulacrum]

Correct, it would be part of the 1.50 release. You can check the assigned milestone to know which release a merged PR is scheduled for.

[bors]

💥 Test timed out

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[Mark-Simulacrum]

@bors retry - spurious timeout

[bors]

⌛ Testing commit 8cfaf94 with merge 5b104fc...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 5b104fc to master...