require gat substs to be invariant #80558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
added
the
F-generic_associated_types
This comment has been minimized.
This comment has been minimized.
| // When dealing with generic associated types we require | ||
| // their generic arguments to be invariant. | ||
| let gat_substs = &data.substs[trait_ref.substs.len()..]; | ||
| self.add_constraints_from_invariant_substs(current, gat_substs, variance); |
There was a problem hiding this comment.
I think that calling add_constraints_from_invariant_substs directly on all of the substs makes more sense here.
There was a problem hiding this comment.
think so too, should have spend some time actually looking at add_constraints_for_trait_ref
|
@bors r+ |
|
📌 Commit 5d641b649b1b0f5b4595914a63de111b996794be has been approved by |
bors
added
S-waiting-on-bors
|
removed some unnecessary changes |
|
@bors r+ |
|
📌 Commit f32a6ac has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69184, fixes #80766
r? @matthewjasper probably