introduce future-compatibility warning for forbidden lint groups #81556

nikomatsakis · 2021-01-30T15:06:33Z

We used to ignore forbid(group) scenarios completely. This changed in #78864, but that led to a number of regressions (#80988, #81218).

This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect.

r? @Mark-Simulacrum

nikomatsakis · 2021-01-30T15:06:42Z

cc @pnkfelix

nikomatsakis · 2021-01-30T15:07:20Z

compiler/rustc_lint/src/context.rs

+        );
+        let lint_name_str = &*lint_name.as_str();
+        self.lint_groups.contains_key(&lint_name_str) || {
+            let warnings_name_str = crate::WARNINGS.name_lower();


For some reason, WARNINGS is not in this list.

Hmm. Are there any other "obvious" groups that might also be not on that list for some reason?

No. The reason for WARNINGS is that it is mega hardcoded in the way that it's implemented; it's not a real lint group.

nikomatsakis · 2021-01-30T15:08:05Z

compiler/rustc_lint/src/levels.rs

+                    );
+                    decorate_diag_builder(diag_builder);
+                } else {
+                    self.struct_lint(


The logic for creating lints and errors is setup in annoyingly non-analogous ways, but I resisted deeper refactorings.

nikomatsakis · 2021-01-30T15:08:26Z

compiler/rustc_lint/src/context.rs

+            lint_name,
+            self.lint_groups.keys().collect::<Vec<_>>()
+        );
+        let lint_name_str = &*lint_name.as_str();


I don't know why everything with lints uses as keys, but I couldn't find other ways to do comparisons.

rust-log-analyzer · 2021-01-30T15:41:05Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 29 tests
iiiiiiiiiiiiiiiiiiiiiiiiiiiii

Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
 finished in 0.074 seconds
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 116 tests
iiiiiiiiii.i.i...i.i..ii....i.i....ii..........iiii.........i.....i...i.......ii.i.ii.....iiii.....i 100/116
test result: ok. 78 passed; 0 failed; 38 ignored; 0 measured; 0 filtered out; finished in 2.30s

 finished in 2.369 seconds
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
---
doc tests for: /checkout/src/doc/rustc/src/what-is-rustc.md
Set({"src/tools/lint-docs"}) not skipped for "bootstrap::test::LintDocs" -- not in ["src/tools/tidy"]
 finished in 0.766 seconds
Generating lint docs (x86_64-unknown-linux-gnu)
error: failed to test example in lint docs for `forbidden_lint_groups` in /checkout/compiler/rustc_lint_defs/src/builtin.rs:12: lint docs should contain the line `### Explanation`



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/lint-docs" "--src" "/checkout/compiler" "--out" "/checkout/obj/build/x86_64-unknown-linux-gnu/md-doc/rustc/src/lints" "--rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustc-target" "x86_64-unknown-linux-gnu" "--validate"

This error was generated by the lint-docs tool.
This error was generated by the lint-docs tool.
This tool extracts documentation for lints from the source code and places
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:31:15
Build completed unsuccessfully in 0:31:15
them in the rustc book. See the declare_lint! documentation
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_lint_defs/macro.declare_lint.html
for an example of the format of documentation this tool expects.

To re-run these tests, run: ./x.py test --keep-stage=0 src/tools/lint-docs
The --keep-stage flag should be used if you have already built the compiler

pnkfelix · 2021-02-01T15:44:58Z

src/test/ui/lint/forbid-group-group-1.rs

@@ -0,0 +1,13 @@
+// Check what happens when we forbid a smaller group but
+// then deny a superset of that group.


nit on comment: you're allowing the superset warnings below, not denying it.

pnkfelix · 2021-02-01T15:47:53Z

src/test/ui/lint/forbid-group-group-1.rs

+
+#![forbid(nonstandard_style)]
+
+// FIXME: Arguably this should be an error, but the WARNINGS group is


does this mean you should have a different test that tries this subset/superset case using something other than the special cased WARNINGS group?

(or is the WARNINGS group the only instance of a superset in the first place...?)

I couldn't find any other group to use.

pnkfelix · 2021-02-01T16:07:01Z

src/test/ui/lint/issue-80988.rs

+//~| WARNING being phased out
+//~| WARNING incompatible with previous forbid
+//~| WARNING being phased out
+//~| WARNING incompatible with previous forbid


sigh. I'm sure the 4x repetition is an artifact of the existing code, and we don't want to deal with fixing it on something that we are beta-backporting. (And I hope that the compiler's de-duplication of diagnostics turns it into a single message.)

But still: Sigh.

pnkfelix · 2021-02-01T16:07:56Z

@bors r+

bors · 2021-02-01T16:07:58Z

📌 Commit 59c43a7a1efb653573e3c9623c35189208362cc9 has been approved by pnkfelix

ehuss · 2021-02-01T16:50:56Z

@bors r-

This has errors that need to be resolved first.

We used to ignore `forbid(group)` scenarios completely. This changed in rust-lang#78864, but that led to a number of regressions (rust-lang#80988, rust-lang#81218). This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect.

nikomatsakis · 2021-02-02T23:21:55Z

@bors r=pnkfelix

bors · 2021-02-02T23:21:57Z

📌 Commit b6b897b has been approved by pnkfelix

…lint, r=pnkfelix introduce future-compatibility warning for forbidden lint groups We used to ignore `forbid(group)` scenarios completely. This changed in rust-lang#78864, but that led to a number of regressions (rust-lang#80988, rust-lang#81218). This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect. r? `@Mark-Simulacrum`

…lint, r=pnkfelix introduce future-compatibility warning for forbidden lint groups We used to ignore `forbid(group)` scenarios completely. This changed in rust-lang#78864, but that led to a number of regressions (rust-lang#80988, rust-lang#81218). This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect. r? ``@Mark-Simulacrum``

…lint, r=pnkfelix introduce future-compatibility warning for forbidden lint groups We used to ignore `forbid(group)` scenarios completely. This changed in rust-lang#78864, but that led to a number of regressions (rust-lang#80988, rust-lang#81218). This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect. r? ```@Mark-Simulacrum```

apiraino · 2021-02-04T16:11:15Z

beta backport approved as per team compiler meeting discussion

…lint, r=pnkfelix introduce future-compatibility warning for forbidden lint groups We used to ignore `forbid(group)` scenarios completely. This changed in rust-lang#78864, but that led to a number of regressions (rust-lang#80988, rust-lang#81218). This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect. r? `@Mark-Simulacrum`

Rollup of 9 pull requests Successful merges: - rust-lang#74304 (Stabilize the Wake trait) - rust-lang#79805 (Rename Iterator::fold_first to reduce and stabilize it) - rust-lang#81556 (introduce future-compatibility warning for forbidden lint groups) - rust-lang#81645 (Add lint for `panic!(123)` which is not accepted in Rust 2021.) - rust-lang#81710 (OsStr eq_ignore_ascii_case takes arg by value) - rust-lang#81711 (add #[inline] to all the public IpAddr functions) - rust-lang#81725 (Move test to be with the others) - rust-lang#81727 (Revert stabilizing integer::BITS.) - rust-lang#81745 (Stabilize poison API of Once, rename poisoned()) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…lint, r=pnkfelix introduce future-compatibility warning for forbidden lint groups We used to ignore `forbid(group)` scenarios completely. This changed in rust-lang#78864, but that led to a number of regressions (rust-lang#80988, rust-lang#81218). This PR introduces a future compatibility warning for the case where a group is forbidden but then an individual lint within that group is allowed. We now issue a FCW when we see the "allow", but permit it to take effect. r? ``@Mark-Simulacrum``

[beta] backports This backports: * CI: only copy python.exe to python3.exe if the latter does not exist rust-lang#81762 * Make hitting the recursion limit in projection non-fatal rust-lang#81055 * Remove incorrect `delay_span_bug` rust-lang#81532 * introduce future-compatibility warning for forbidden lint groups rust-lang#81556 * Update cargo rust-lang#81755 * rustdoc: Fix visibility of trait and impl items rust-lang#81288 * Work around missing -dev packages in solaris docker image. rust-lang#81229 * Update LayoutError/LayoutErr stability attributes rust-lang#81767 * Revert 78373 ("dont leak return value after panic in drop") rust-lang#81257 * Rename `panic_fmt` lint to `non_fmt_panic` rust-lang#81729

rust-highfive assigned Mark-Simulacrum Jan 30, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2021

nikomatsakis added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 30, 2021

nikomatsakis commented Jan 30, 2021

View reviewed changes

pnkfelix reviewed Feb 1, 2021

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2021

pnkfelix added C-future-compatibility Category: Future-compatibility lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2021

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 1, 2021

nikomatsakis force-pushed the forbidden-lint-groups-lint branch from 59c43a7 to 66ce370 Compare February 2, 2021 23:19

nikomatsakis force-pushed the forbidden-lint-groups-lint branch from 66ce370 to b6b897b Compare February 2, 2021 23:21

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2021

m-ou-se mentioned this pull request Feb 3, 2021

Rollup of 5 pull requests #81707

Closed

Dylan-DPC-zz mentioned this pull request Feb 3, 2021

Rollup of 11 pull requests #81733

Closed

m-ou-se mentioned this pull request Feb 4, 2021

Rollup of 12 pull requests #81748

Closed

apiraino added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 4, 2021

m-ou-se mentioned this pull request Feb 4, 2021

Rollup of 14 pull requests #81754

Closed

m-ou-se mentioned this pull request Feb 4, 2021

Rollup of 9 pull requests #81761

Merged

bors merged commit c5990dd into rust-lang:master Feb 5, 2021

rustbot added this to the 1.51.0 milestone Feb 5, 2021

ehuss mentioned this pull request Feb 5, 2021

[beta] backports #81774

Merged

ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 5, 2021

Enselic mentioned this pull request Jul 24, 2023

When lint attributes in the same scope overlap, all but the last declared one are dropped #53079

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introduce future-compatibility warning for forbidden lint groups #81556

introduce future-compatibility warning for forbidden lint groups #81556

nikomatsakis commented Jan 30, 2021

nikomatsakis commented Jan 30, 2021

nikomatsakis Jan 30, 2021

pnkfelix Feb 1, 2021

nikomatsakis Feb 2, 2021

nikomatsakis Jan 30, 2021

nikomatsakis Jan 30, 2021

rust-log-analyzer commented Jan 30, 2021

pnkfelix Feb 1, 2021

pnkfelix Feb 1, 2021

nikomatsakis Feb 2, 2021

pnkfelix Feb 1, 2021

pnkfelix commented Feb 1, 2021

bors commented Feb 1, 2021

ehuss commented Feb 1, 2021

nikomatsakis commented Feb 2, 2021

bors commented Feb 2, 2021

apiraino commented Feb 4, 2021

		@@ -0,0 +1,13 @@
		// Check what happens when we forbid a smaller group but
		// then deny a superset of that group.


		#![forbid(nonstandard_style)]

		// FIXME: Arguably this should be an error, but the WARNINGS group is

introduce future-compatibility warning for forbidden lint groups #81556

introduce future-compatibility warning for forbidden lint groups #81556

Conversation

nikomatsakis commented Jan 30, 2021

nikomatsakis commented Jan 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rust-log-analyzer commented Jan 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pnkfelix commented Feb 1, 2021

bors commented Feb 1, 2021

ehuss commented Feb 1, 2021

nikomatsakis commented Feb 2, 2021

bors commented Feb 2, 2021

apiraino commented Feb 4, 2021