Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when emitting diagnostic for closure mutable binding error #81717

Merged
merged 1 commit into from Feb 3, 2021

Conversation

Aaron1011
Copy link
Member

Fixes #81700

The upvar borrow kind may be ty::BorrowKind::UniqueImmBorrow, which is
still a mutable borrow for the purposes of this diagnostic code.

Fixes rust-lang#81700

The upvar borrow kind may be `ty::BorrowKind::UniqueImmBorrow`, which is
still a mutable borrow for the purposes of this diagnostic code.
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2021
@estebank
Copy link
Contributor

estebank commented Feb 3, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2021

📌 Commit bc84e21 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2021
@Aaron1011
Copy link
Member Author

This fixes a P-High issue

@bors p=1

@bors
Copy link
Contributor

bors commented Feb 3, 2021

⌛ Testing commit bc84e21 with merge e708cbd...

@bors
Copy link
Contributor

bors commented Feb 3, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing e708cbd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 3, 2021
@bors bors merged commit e708cbd into rust-lang:master Feb 3, 2021
@rustbot rustbot added this to the 1.51.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICE] With closure on mutable ref
5 participants