-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #83301
Rollup of 11 pull requests #83301
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2cbea9f - Browse repository at this point
Copy the full SHA 2cbea9fView commit details
Commits on Mar 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bbbefa3 - Browse repository at this point
Copy the full SHA bbbefa3View commit details
Commits on Mar 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2069d3e - Browse repository at this point
Copy the full SHA 2069d3eView commit details -
Improve code by removing similar function calls and using loops inste…
…ad for collecting iterators
Configuration menu - View commit details
-
Copy full SHA for 1d26e6b - Browse repository at this point
Copy the full SHA 1d26e6bView commit details
Commits on Mar 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cad3c42 - Browse repository at this point
Copy the full SHA cad3c42View commit details
Commits on Mar 17, 2021
-
Remove unnecessary
forward_inner_docs
hackand replace it with `extended_key_value_attributes` feature.
Configuration menu - View commit details
-
Copy full SHA for bb7c04a - Browse repository at this point
Copy the full SHA bb7c04aView commit details -
Move some test-only code to test files
This also relaxes the bounds on some structs and moves them to the impl block instead.
Configuration menu - View commit details
-
Copy full SHA for 620ecc0 - Browse repository at this point
Copy the full SHA 620ecc0View commit details -
Fix gitattibutes for old git versions
Jethro Beekman committedMar 17, 2021 Configuration menu - View commit details
-
Copy full SHA for b1de9d4 - Browse repository at this point
Copy the full SHA b1de9d4View commit details
Commits on Mar 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cfb4ad4 - Browse repository at this point
Copy the full SHA cfb4ad4View commit details -
Extend
proc_macro_back_compat
lint toactix-web
Unlike the other cases of this lint, there's no simple way to detect if an old version of the relevant crate (`syn`) is in use. The `actix-web` crate only depends on `pin-project` v1.0.0, so checking the version of `actix-web` does not guarantee that a new enough version of `pin-project` (and therefore `syn`) is in use. Instead, we rely on the fact that virtually all of the regressed crates are pinned to a pre-1.0 version of `pin-project`. When this is the case, bumping the `actix-web` dependency will pull in the *latest* version of `pin-project`, which has an explicit dependency on a newer v dependency on a newer version of `syn`. The lint message tells users to update `actix-web`, since that's what they're most likely to have control over. We could potentially tell them to run `cargo update -p syn`, but I think it's more straightforward to suggest an explicit change to the `Cargo.toml` The `actori-web` fork had its last commit over a year ago, and appears to just be a renamed fork of `actix-web`. Therefore, I've removed the `actori-web` check entirely - any crates that actually get broken can simply update `syn` themselves.
Configuration menu - View commit details
-
Copy full SHA for 390d1ef - Browse repository at this point
Copy the full SHA 390d1efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 458d044 - Browse repository at this point
Copy the full SHA 458d044View commit details -
Fix typo/inaccuracy in the documentation of Iterator::skip_while
One of the examples used to say “this leads to a possibly confusing situation, where the type of the closure is a double reference” while _actually_ referring to the type of the closure _argument_.
Configuration menu - View commit details
-
Copy full SHA for 99b2054 - Browse repository at this point
Copy the full SHA 99b2054View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dfda62 - Browse repository at this point
Copy the full SHA 9dfda62View commit details
Commits on Mar 19, 2021
-
Rollup merge of rust-lang#82500 - CDirkx:hermit-pipe, r=joshtriplett
Reuse `std::sys::unsupported::pipe` on `hermit` Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`: ```rust #[path = "../unsupported/pipe.rs"] pub mod pipe; ```
Configuration menu - View commit details
-
Copy full SHA for 4abcd40 - Browse repository at this point
Copy the full SHA 4abcd40View commit details -
Rollup merge of rust-lang#82759 - m-ou-se:remove-unwrap-none, r=petro…
…chenkov Remove unwrap_none/expect_none from compiler/. We're not going to stabilize `Option::{unwrap_none, expect_none}`. (See rust-lang#62633.) This removes the usage of those unstable methods from `compiler/`.
Configuration menu - View commit details
-
Copy full SHA for 2960971 - Browse repository at this point
Copy the full SHA 2960971View commit details -
Rollup merge of rust-lang#82846 - GuillaumeGomez:doc-alias-list, r=jy…
…n514 rustdoc: allow list syntax for #[doc(alias)] attributes Fixes rust-lang#81205. It now allows to have: ```rust #[doc(alias = "x")] // and: #[doc(alias("y", "z"))] ``` cc ``@jplatte`` r? ``@jyn514``
Configuration menu - View commit details
-
Copy full SHA for 61372e1 - Browse repository at this point
Copy the full SHA 61372e1View commit details -
Rollup merge of rust-lang#82892 - jix:clarify-read-read, r=joshtriplett
Clarify docs for Read::read's return value Right now the docs for `Read::read`'s return value are phrased in a way that makes it easy for the reader to assume that the return value is never larger than the passed buffer. This PR clarifies that this is a requirement for implementations of the trait, but that callers have to expect a buggy yet safe implementation failing to do so, especially if unchecked accesses to the buffer are done afterwards. I fell into this trap recently, and when I noticed, I looked at the docs again and had the feeling that I might not have been the first one to miss this. The same issue of trusting the return value of `read` was also present in std itself for about 2.5 years and only fixed recently, see rust-lang#80895. I hope that clarifying the docs might help others to avoid this issue.
Configuration menu - View commit details
-
Copy full SHA for db4a97c - Browse repository at this point
Copy the full SHA db4a97cView commit details -
Rollup merge of rust-lang#83179 - Aaron1011:actix-web-lint, r=petroch…
…enkov Extend `proc_macro_back_compat` lint to `actix-web` Unlike the other cases of this lint, there's no simple way to detect if an old version of the relevant crate (`syn`) is in use. The `actix-web` crate only depends on `pin-project` v1.0.0, so checking the version of `actix-web` does not guarantee that a new enough version of `pin-project` (and therefore `syn`) is in use. Instead, we rely on the fact that virtually all of the regressed crates are pinned to a pre-1.0 version of `pin-project`. When this is the case, bumping the `actix-web` dependency will pull in the *latest* version of `pin-project`, which has an explicit dependency on a newer v dependency on a newer version of `syn`. The lint message tells users to update `actix-web`, since that's what they're most likely to have control over. We could potentially tell them to run `cargo update -p syn`, but I think it's more straightforward to suggest an explicit change to the `Cargo.toml` The `actori-web` fork had its last commit over a year ago, and appears to just be a renamed fork of `actix-web`. Therefore, I've removed the `actori-web` check entirely - any crates that actually get broken can simply update `syn` themselves.
Configuration menu - View commit details
-
Copy full SHA for 75571a5 - Browse repository at this point
Copy the full SHA 75571a5View commit details -
Rollup merge of rust-lang#83197 - jyn514:cfg-test-dead-code, r=joshtr…
…iplett Move some test-only code to test files Split out from rust-lang#83185.
Configuration menu - View commit details
-
Copy full SHA for 37b7031 - Browse repository at this point
Copy the full SHA 37b7031View commit details -
Rollup merge of rust-lang#83208 - jethrogb:jb/gitignore, r=Xanewok
Fix gitattibutes for old git versions
Configuration menu - View commit details
-
Copy full SHA for 3591242 - Browse repository at this point
Copy the full SHA 3591242View commit details -
Rollup merge of rust-lang#83215 - bstrie:dephaikuraw, r=joshtriplett
Deprecate std::os::haiku::raw, which accidentally wasn't deprecated In early 2016, all `std::os::*::raw` modules [were deprecated](rust-lang@aa23c98) in accordance with [RFC 1415](https://github.com/rust-lang/rfcs/blob/master/text/1415-trim-std-os.md). However, at this same time support for Haiku was being added to libstd, landing shortly after the aforementioned commit, and due to some crossed wires a `std::os::haiku::raw` module was added and was not marked as deprecated. I have been in correspondence with the author of the Haiku patch, ````@nielx,```` who has confirmed that this was simply an oversight and that the definitions from the libc crate should be preferred instead.
Configuration menu - View commit details
-
Copy full SHA for 675ae2e - Browse repository at this point
Copy the full SHA 675ae2eView commit details -
Rollup merge of rust-lang#83230 - jyn514:remove-macros, r=joshtriplett
Remove unnecessary `forward_inner_docs` hack and replace it with `extended_key_value_attributes` feature. This is rust-lang#79150, but for compiler/.
Configuration menu - View commit details
-
Copy full SHA for 827ad66 - Browse repository at this point
Copy the full SHA 827ad66View commit details -
Rollup merge of rust-lang#83236 - cjgillot:memmap, r=joshtriplett
Upgrade memmap to memmap2 memmap is no longer maintained. memmap2 is a fork that is still maintained. https://rustsec.org/advisories/RUSTSEC-2020-0077.html The remaining use of memmap is through measureme.
Configuration menu - View commit details
-
Copy full SHA for 23128c4 - Browse repository at this point
Copy the full SHA 23128c4View commit details -
Rollup merge of rust-lang#83270 - steffahn:missing_word_in_skip_while…
…_doc, r=joshtriplett Fix typo/inaccuracy in the documentation of Iterator::skip_while One of the examples used to say “this leads to a possibly confusing situation, where the type of the closure is a double reference” while _actually_ referring to the type of the closure _argument_. This PR just changes a single word in documentation. `````@rustbot````` modify labels: A-iterators, T-doc, T-lang
Configuration menu - View commit details
-
Copy full SHA for 99f411d - Browse repository at this point
Copy the full SHA 99f411dView commit details