Expose str::SplitInclusive in alloc and therefore in std #83408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been omitted from the beginning when this feature was first introduced in 86bf962. Most users won't need to name this type which is probably why this wasn't noticed in the meantime. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hrm, I should have said I think. I wonder if I can do that now. |
dtolnay
approved these changes
Mar 24, 2021
dtolnay
force-pushed
the
expose-splitinclusive
branch
from
553d04a
to
633a66f
Compare
|
Bumping stability attribute to the release corresponding to current nightly (1.53.0) since I don't see this warranting a backport, although we certainly could if someone needs it. |
|
@bors r+ |
|
📌 Commit 633a66f has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been omitted from the beginning when this feature was first introduced in 86bf962. Most users won't need to name this type which is probably why this wasn't noticed in the meantime.
See #83372 for a different but related bug.
Notes for reviewers
I think I have got this right but TBH I am not very familiar with the relationship between core and std and so on.
I also haven't don't any kind of test (not even a build) yet. I will do a local docs build to see that the type now appears in the std docs.I did a local docs build and it has made this type appear asstd::str::SplitInclusiveas expectedThe linkification of the return value from
str::split_inclusiveteleports me to the online url forcore::str::SplitInclusive. I think this may be a rustdoc anomaly (similar to #79630 maybe) but I am not sure. Perhaps it means I haven't done thestd->corereferrence correctly.I made this insta-stable since it seems like simply a bug. Please LMK if that is not right. (edited to add:) In particular, IDK how this ought to relate to the (?)current release process.