Tests: Remove redundant ignore-tidy-linelength annotations
#83807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'm having some trouble with the codegen and codegen-units tests: I have removed now-redundant (CC @RalfJung) |
This comment has been minimized.
This comment has been minimized.
|
I'm sorry I have no idea, I don't usually touch those tests. Maybe just leave that for a future PR, then we can try to ping some people that hopefully know more. |
|
This looks pretty clear though: There are line numbers in this, and indeed |
RalfJung
reviewed
Apr 3, 2021
This is step 2 towards fixing rust-lang#77548. In the codegen and codegen-units test suites, the `//` comment markers were kept in order not to affect any source locations. This is because these tests cannot be automatically `--bless`ed.
sjakobi
force-pushed
the
77548-remove-ignore-annotations
branch
from
c242a87
to
3ea62cb
Compare
sjakobi
commented
Apr 3, 2021
| @@ -1,26 +0,0 @@ | |||
| error: symbol-name(_ZN5impl13foo3Foo3bar17he53b9bee7600ed8dE) | |||
There was a problem hiding this comment.
I'm not sure why this file was removed – I suspect that --bless did it.
There was a problem hiding this comment.
The corresponding legacy.stderr and v0.stderr files were updated though. Maybe some kind of "vanilla" test mode was skipped?!
sjakobi
commented
Apr 3, 2021
| @@ -1,20 +0,0 @@ | |||
| error: symbol-name(_ZN11issue_609253foo36Foo$LT$issue_60925..llv$6d$..Foo$GT$3foo17h059a991a004536adE) | |||
There was a problem hiding this comment.
Same with this file.
|
Both file deletions do seem strange, but ultimately I'm not sure why the original files were there, so seems OK to drop them -- they don't appear to be testing anything that I can see. We'll see if full CI complains, of course. @bors r+ rollup=iffy |
|
📌 Commit 3ea62cb has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 4, 2021
…ions, r=Mark-Simulacrum Tests: Remove redundant `ignore-tidy-linelength` annotations This is step 2 towards fixing rust-lang#77548. In the codegen and codegen-units test suites, the `//` comment markers were kept in order not to affect any source locations. This is because these tests cannot be automatically `--bless`ed.
This was referenced Apr 4, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#80525 (wasm64 support) - rust-lang#83019 (core: disable `ptr::swap_nonoverlapping_one`'s block optimization on SPIR-V.) - rust-lang#83717 (rustdoc: Separate filter-empty-string out into its own function) - rust-lang#83807 (Tests: Remove redundant `ignore-tidy-linelength` annotations) - rust-lang#83815 (ptr::addr_of documentation improvements) - rust-lang#83820 (Remove attribute `#[link_args]`) - rust-lang#83841 (Allow clobbering unsupported registers in asm!) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 2 towards fixing #77548.
In the codegen and codegen-units test suites, the
//comment markerswere kept in order not to affect any source locations. This is because
these tests cannot be automatically
--blessed.