Add coverage to continue statements #84295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
`continue` statements were missing coverage. This was particularly noticeable in a match pattern that contained only a `continue` statement, leaving the branch appear uncounted. This PR addresses the problem and adds tests to prove it.
richkadel
force-pushed
the
continue-coverage
branch
from
b320332
to
448e52d
Compare
richkadel
commented
Apr 18, 2021
tmiasko
reviewed
Apr 18, 2021
And make the LocalDecl internal, to avoid needing to declare storage. (For multiple `continue` stateuemtns, it must also be mutable.)
richkadel
force-pushed
the
continue-coverage
branch
from
9b8d490
to
d1d7fb1
Compare
tmandry
reviewed
Apr 20, 2021
| @@ -643,6 +650,14 @@ impl<'a, 'tcx> Builder<'a, 'tcx> { | |||
| self.cfg.start_new_block().unit() | |||
| } | |||
|
|
|||
| // Add a dummy `Assign` statement to the CFG, with the span for the source code's `continue` | |||
There was a problem hiding this comment.
nit: the function itself doesn't know about continue
Comment on lines
+10
to
+15
| 9| | true => { | ||
| 10| 10| continue; | ||
| 11| | } | ||
| 12| 0| _ => { | ||
| 13| 0| x = 1; | ||
| 14| 0| } |
There was a problem hiding this comment.
small detail, but can you think of why the beginning/end of the block have counters for the _ / x = 1 case, but not the continue?
|
This makes sense to me. Comments above shouldn't block merging, so @bors r+ |
|
📌 Commit d1d7fb1 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuestatements were missing coverage. This was particularlynoticeable in a match pattern that contained only a
continuestatement, leaving the branch appear uncounted. This PR addresses the
problem and adds tests to prove it.
r? @tmandry
cc: @wesleywiser