Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test tidy should ignore alternative build dir patterns #84530

Merged
merged 1 commit into from
Apr 29, 2021

Commits on Apr 24, 2021

  1. test tidy should ignore alternative build dir patterns

    I need to have multiple `build` directories, such as `build`,
    `build-fuchsia`, and `build-test`. But when I'm uploading a change, I
    run `./x.py test tidy`, and if I have a `build-something` directory with
    Rust sources, I git a bunch of formatting errors.
    
    `rustfmt.toml` only ignores the directory named `build`.
    
    This change extends the patterns to also ignore `build-*` and `*-build`.
    
    As a rustc contributor, I not only build the rust compiler to develop
    new features, but I also build alternative "distributions" (using
    secondary `*-config.toml` files with different configurations),
    including:
    
    * To occasionally rebuild a version of the compiler that `rust-analyzer`
    can use to `check` source (which fixes issues in the VS Code UI, so
    changing and rebuilding the compiler does not break VS Code editing Rust
    code).
    * To build custom distributions for Fuchsia
    * To build test distributions when working on changes to `bootstrap`
    (e.g., when I recently added `rust-demangler` to distributions)
    richkadel committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    79020a8 View commit details
    Browse the repository at this point in the history