Encode spans relative to the enclosing item -- enable on nightly #84762

cjgillot · 2021-04-30T18:52:38Z

Follow-up to #84373 with the flag -Zincremental-relative-spans set by default.

This PR seeks to remove one of the main shortcomings of incremental: the handling of spans.
Changing the contents of a function may require redoing part of the compilation process for another function in another file because of span information is changed.
Within one file: all the spans in HIR change, so typechecking had to be re-done.
Between files: spans of associated types/consts/functions change, so type-based resolution needs to be re-done (hygiene information is stored in the span).

The flag -Zincremental-relative-spans encodes local spans relative to the span of an item, stored inside the source_span query.

Trap: stashed diagnostics are referenced by the "raw" span, so stealing them requires to remove the span's parent.

In order to avoid too much traffic in the span interner, span encoding uses the ctxt_or_tag field to encode:

the parent when the SyntaxContext is 0;
the SyntaxContext when the parent is None.
Even with this, the PR creates a lot of traffic to the Span interner, when a Span has both a LocalDefId parent and a non-root SyntaxContext. They appear in lowering, when we add a parent to all spans, including those which come from macros, and during inlining when we mark inlined spans.

The last commit changes how queries of LocalDefId manage their cache. I can put this in a separate PR if required.

Possible future directions:

validate that all spans are marked in HIR validation;
mark macro-expanded spans relative to the def-site and not the use-site.

cjgillot · 2021-04-30T19:19:25Z

@bors try @rust-timer queue

rust-timer · 2021-04-30T19:19:26Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-04-30T19:19:34Z

⌛ Trying commit 0cadd9de4986fb7044d22b242bf514ff674d9384 with merge 3c172eeb011b95ff8df485a4979d875ae919ce24...

bors · 2021-04-30T20:00:43Z

☀️ Try build successful - checks-actions
Build commit: 3c172eeb011b95ff8df485a4979d875ae919ce24 (3c172eeb011b95ff8df485a4979d875ae919ce24)

rust-timer · 2021-04-30T20:00:45Z

Queued 3c172eeb011b95ff8df485a4979d875ae919ce24 with parent 8fef006, future comparison URL.

rust-timer · 2021-04-30T22:18:18Z

Finished benchmarking try commit (3c172eeb011b95ff8df485a4979d875ae919ce24): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

cjgillot · 2021-05-02T21:26:12Z

@bors try @rust-timer queue

rust-timer · 2021-05-02T21:26:14Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-05-02T21:26:21Z

⌛ Trying commit 8d7131dfdeb2f5d52207e2acb8566d1e906d6af8 with merge 0355bb6a9f6aca12079750fb694c0353bf2533b2...

bors · 2021-05-02T22:12:20Z

☀️ Try build successful - checks-actions
Build commit: 0355bb6a9f6aca12079750fb694c0353bf2533b2 (0355bb6a9f6aca12079750fb694c0353bf2533b2)

rust-timer · 2021-05-02T22:12:22Z

Queued 0355bb6a9f6aca12079750fb694c0353bf2533b2 with parent e10cbc3, future comparison URL.

rust-timer · 2021-05-03T07:20:11Z

Finished benchmarking try commit (0355bb6a9f6aca12079750fb694c0353bf2533b2): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

The diagnostics are replayed at the correct place anyway.

petrochenkov · 2023-01-02T11:13:25Z

@bors r+

bors · 2023-01-02T11:13:27Z

📌 Commit 7b6ead2 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2023-01-02T13:10:19Z

⌛ Testing commit 7b6ead2 with merge fb9dfa8...

bors · 2023-01-02T16:04:25Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing fb9dfa8 to master...

rust-timer · 2023-01-02T17:30:58Z

Finished benchmarking commit (fb9dfa8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.2%, 5.0%]	108
Regressions ❌ (secondary)	1.8%	[0.2%, 7.6%]	90
Improvements ✅ (primary)	-20.0%	[-68.9%, -0.6%]	25
Improvements ✅ (secondary)	-2.7%	[-4.8%, -1.5%]	11
All ❌✅ (primary)	-2.4%	[-68.9%, 5.0%]	133

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[0.7%, 7.9%]	60
Regressions ❌ (secondary)	5.2%	[1.9%, 8.0%]	11
Improvements ✅ (primary)	-9.4%	[-32.6%, -1.5%]	17
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-32.6%, 7.9%]	77

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[1.1%, 6.4%]	38
Regressions ❌ (secondary)	3.2%	[1.3%, 4.4%]	22
Improvements ✅ (primary)	-19.0%	[-68.6%, -1.9%]	29
Improvements ✅ (secondary)	-5.7%	[-13.0%, -2.7%]	15
All ❌✅ (primary)	-6.5%	[-68.6%, 6.4%]	67

rylev · 2023-01-03T17:15:56Z

There was an FCP on whether the performance regression in some benchmarks were worth it which passed.

@rustbot label perf-regression-triaged

…nkov Encode spans relative to the enclosing item -- enable on nightly Follow-up to rust-lang#84373 with the flag `-Zincremental-relative-spans` set by default. This PR seeks to remove one of the main shortcomings of incremental: the handling of spans. Changing the contents of a function may require redoing part of the compilation process for another function in another file because of span information is changed. Within one file: all the spans in HIR change, so typechecking had to be re-done. Between files: spans of associated types/consts/functions change, so type-based resolution needs to be re-done (hygiene information is stored in the span). The flag `-Zincremental-relative-spans` encodes local spans relative to the span of an item, stored inside the `source_span` query. Trap: stashed diagnostics are referenced by the "raw" span, so stealing them requires to remove the span's parent. In order to avoid too much traffic in the span interner, span encoding uses the `ctxt_or_tag` field to encode: - the parent when the `SyntaxContext` is 0; - the `SyntaxContext` when the parent is `None`. Even with this, the PR creates a lot of traffic to the Span interner, when a Span has both a LocalDefId parent and a non-root SyntaxContext. They appear in lowering, when we add a parent to all spans, including those which come from macros, and during inlining when we mark inlined spans. The last commit changes how queries of `LocalDefId` manage their cache. I can put this in a separate PR if required. Possible future directions: - validate that all spans are marked in HIR validation; - mark macro-expanded spans relative to the def-site and not the use-site.

dtolnay · 2023-01-07T18:24:45Z

This had what seems to be an unintended effect on JSON diagnostics: #106571.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647)

Pkgsrc changes: * Adjust patches (add & remove) and cargo checksums to new versions. * It's conceivable that the workaround for LLVM based NetBSD works even less in this version (ref. PKGSRC_HAVE_LIBCPP not having a corresponding patch anymore). Upstream changes: Version 1.68.2 (2023-03-28) =========================== - [Update the GitHub RSA host key bundled within Cargo] (rust-lang/cargo#11883). The key was [rotated by GitHub] (https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/) on 2023-03-24 after the old one leaked. - [Mark the old GitHub RSA host key as revoked] (rust-lang/cargo#11889). This will prevent Cargo from accepting the leaked key even when trusted by the system. - [Add support for `@revoked` and a better error message for `@cert-authority` in Cargo's SSH host key verification] (rust-lang/cargo#11635) Version 1.68.1 (2023-03-23) =========================== - [Fix miscompilation in produced Windows MSVC artifacts] (rust-lang/rust#109094) This was introduced by enabling ThinLTO for the distributed rustc which led to miscompilations in the resulting binary. Currently this is believed to be limited to the -Zdylib-lto flag used for rustc compilation, rather than a general bug in ThinLTO, so only rustc artifacts should be affected. - [Fix --enable-local-rust builds] (rust-lang/rust#109111) - [Treat `$prefix-clang` as `clang` in linker detection code] (rust-lang/rust#109156) - [Fix panic in compiler code] (rust-lang/rust#108162) Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647) Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

…avidtwco Enable incremental-relative-spans by default. This was enabled on nightly in rust-lang#84762. It has been a while, without obvious bugs. It's time to enable it by default for incremental runs.

Enable incremental-relative-spans by default. This was enabled on nightly in rust-lang/rust#84762. It has been a while, without obvious bugs. It's time to enable it by default for incremental runs.

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 30, 2021

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 30, 2021

cjgillot force-pushed the resolve-span-opt branch from 0cadd9d to 8d7131d Compare May 2, 2021 21:22

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 3, 2021

cjgillot force-pushed the resolve-span-opt branch 2 times, most recently from e6448db to 8fd8ff9 Compare May 8, 2021 07:46

This comment has been minimized.

Sign in to view

cjgillot mentioned this pull request May 12, 2021

Encode spans relative to the enclosing item #84373

Merged

petrochenkov self-assigned this May 12, 2021

petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2021

cjgillot force-pushed the resolve-span-opt branch 2 times, most recently from e5b631e to 8bb0a62 Compare May 31, 2021 20:03

cjgillot added 3 commits December 25, 2022 18:48

Ignore span references from diagnostics.

4719cb3

The diagnostics are replayed at the correct place anyway.

Remove references to removed option from tests.

5b9360b

Explain disabled span hashing.

7b6ead2

cjgillot force-pushed the resolve-span-opt branch from 8bb31c8 to 7b6ead2 Compare December 25, 2022 18:49

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Dec 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2023

bors merged commit fb9dfa8 into rust-lang:master Jan 2, 2023

rustbot added this to the 1.68.0 milestone Jan 2, 2023

bors mentioned this pull request Jan 2, 2023

Refactoring report_method_error #105752

Merged

cjgillot deleted the resolve-span-opt branch January 2, 2023 17:24

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 3, 2023

apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023

dtolnay mentioned this pull request Jan 7, 2023

Regression: duplicate messages appear in --error-format=json #106571

Open

cjgillot mentioned this pull request Sep 7, 2023

Enable incremental-relative-spans by default. #115656

Merged

nnethercote mentioned this pull request Jan 10, 2024

Cleanup things in and around Diagnostic #119763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encode spans relative to the enclosing item -- enable on nightly #84762

Encode spans relative to the enclosing item -- enable on nightly #84762

cjgillot commented Apr 30, 2021 •

edited

Loading

This comment has been minimized.

cjgillot commented Apr 30, 2021

rust-timer commented Apr 30, 2021

bors commented Apr 30, 2021

bors commented Apr 30, 2021

rust-timer commented Apr 30, 2021

rust-timer commented Apr 30, 2021

cjgillot commented May 2, 2021

rust-timer commented May 2, 2021

bors commented May 2, 2021

bors commented May 2, 2021

rust-timer commented May 2, 2021

rust-timer commented May 3, 2021

This comment has been minimized.

petrochenkov commented Jan 2, 2023

bors commented Jan 2, 2023

bors commented Jan 2, 2023

bors commented Jan 2, 2023

rust-timer commented Jan 2, 2023

rylev commented Jan 3, 2023

dtolnay commented Jan 7, 2023

Encode spans relative to the enclosing item -- enable on nightly #84762

Encode spans relative to the enclosing item -- enable on nightly #84762

Conversation

cjgillot commented Apr 30, 2021 • edited Loading

This comment has been minimized.

cjgillot commented Apr 30, 2021

rust-timer commented Apr 30, 2021

bors commented Apr 30, 2021

bors commented Apr 30, 2021

rust-timer commented Apr 30, 2021

rust-timer commented Apr 30, 2021

cjgillot commented May 2, 2021

rust-timer commented May 2, 2021

bors commented May 2, 2021

bors commented May 2, 2021

rust-timer commented May 2, 2021

rust-timer commented May 3, 2021

This comment has been minimized.

petrochenkov commented Jan 2, 2023

bors commented Jan 2, 2023

bors commented Jan 2, 2023

bors commented Jan 2, 2023

rust-timer commented Jan 2, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

rylev commented Jan 3, 2023

dtolnay commented Jan 7, 2023

cjgillot commented Apr 30, 2021 •

edited

Loading