Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Target for aarch64-unknown-uefi #85358

Closed
wants to merge 9 commits into from
Closed

Add Target for aarch64-unknown-uefi #85358

wants to merge 9 commits into from

Conversation

HTGAzureX1212
Copy link
Contributor

This Pull Request adds a new rustc target configuration called aarch64-unknown-uefi.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2021
@HTGAzureX1212 HTGAzureX1212 marked this pull request as draft May 16, 2021 03:38
@HTGAzureX1212 HTGAzureX1212 marked this pull request as ready for review May 16, 2021 05:12
@petrochenkov
Copy link
Contributor

Hi.
What is the relation of this PR with #85357?
They were submitted at the same time and contain some similar issues (#85357 (comment)).

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2021
@joshtriplett
Copy link
Member

In addition to any other potential issues, this also needs to meet the target tier policy requirements for a new tier 3 target. You'll need to full-quote the tier 3 requirements from https://doc.rust-lang.org/nightly/rustc/target-tier-policy.html and explain how you meet each of them.

@HTGAzureX1212
Copy link
Contributor Author

Good morning @petrochenkov and @joshtriplett; I will write up the reason why this aarch64-unknown-uefi target meets the requirements of a Tier-3 Target later today, thanks.

@petrochenkov
Copy link
Contributor

To avoid doing the same work in two PRs I'm going to close this PR in favor of #85357 which was opened 2 minutes earlier.
@HTG-YT, feel free to collaborate with @Andy-Python-Programmer there.

@HTGAzureX1212 HTGAzureX1212 deleted the aarch64-unknown-uefi branch May 17, 2021 09:25
@HTGAzureX1212
Copy link
Contributor Author

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants