Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove native_link_modifiers from the list of incomplete features. #85606

Merged
merged 1 commit into from
May 24, 2021
Merged

remove native_link_modifiers from the list of incomplete features. #85606

merged 1 commit into from
May 24, 2021

Conversation

12101111
Copy link
Contributor

These features are fully implemented and not incomplete.
The tracking issue of them is #81490.
The implement PR is #83507.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2021
@12101111 12101111 mentioned this pull request May 23, 2021
Merged
@petrochenkov
Copy link
Contributor

r? @petrochenkov @bors r+

@bors
Copy link
Contributor

bors commented May 23, 2021

📌 Commit a90ec5d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2021
@bors
Copy link
Contributor

bors commented May 23, 2021

⌛ Testing commit a90ec5d with merge 9f69e2f...

@luqmana
Copy link
Member

luqmana commented May 23, 2021

I wouldn't say the as-needed modifier is fully implemented. See the FIXME(81490) comment in the code re: lack of being able to detect whether or not the linker supports the necessary flags.

@bors
Copy link
Contributor

bors commented May 24, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 9f69e2f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 24, 2021
@bors bors merged commit 9f69e2f into rust-lang:master May 24, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@12101111 @rust-highfive @petrochenkov @bors @luqmana @Mark-Simulacrum @rustbot