Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off frame pointer elimination on all Apple platforms. #85706

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Turn off frame pointer elimination on all Apple platforms. #85706

merged 1 commit into from
Jun 3, 2021

Commits on Jun 2, 2021

  1. Turn off frame pointer elimination on all Apple platforms. 

    This ends up disabling frame pointer elimination on aarch64_apple_darwin
which matches what clang does by default along with the
aarch64_apple_ios and x86_64_apple_darwin targets.

Further, the Apple docs "Writing ARM64 Code for Apple Platforms" has a section
called "Respect the Purpose of Specific CPU Registers" which
specifically calls out the frame pointer register (x29):

   The frame pointer register (x29) must always address a valid frame
   record. Some functions — such as leaf functions or tail calls — may
   opt not to create an entry in this list As a result, stack traces
   are always meaningful, even without debug information.

Other platforms are updated to not override the default.
    @jrmuizel
    jrmuizel committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    aab8545 View commit details
    Browse the repository at this point in the history