Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict access to crate_name. #85904

Merged
merged 1 commit into from Jun 2, 2021
Merged

Restrict access to crate_name. #85904

merged 1 commit into from Jun 2, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 1, 2021

Also remove original_crate_name, which had the exact same implementation.

Part of #85153

@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 1, 2021

Let's be prudent this time.
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bors
Copy link
Contributor

bors commented Jun 1, 2021

⌛ Trying commit cbf6f172c71d2ca2c7cdfa8e5272af5de30692fc with merge 53fe24fd477615be78e790a70d2e82762858aa69...

@bors
Copy link
Contributor

bors commented Jun 1, 2021

☀️ Try build successful - checks-actions
Build commit: 53fe24fd477615be78e790a70d2e82762858aa69 (53fe24fd477615be78e790a70d2e82762858aa69)

@rust-timer
Copy link
Collaborator

Queued 53fe24fd477615be78e790a70d2e82762858aa69 with parent 7f9ab03, future comparison URL.

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@petrochenkov
Copy link
Contributor

r=me assuming perf is good.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (53fe24fd477615be78e790a70d2e82762858aa69): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 2, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2021
@bors
Copy link
Contributor

bors commented Jun 2, 2021

📌 Commit cbf6f172c71d2ca2c7cdfa8e5272af5de30692fc has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented Jun 2, 2021

⌛ Testing commit cbf6f172c71d2ca2c7cdfa8e5272af5de30692fc with merge f47a5e529b0c4e3f751b401a9f14664963167db6...

@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot
Restrict access to crate_name.
0e71283 
Also remove original_crate_name, which had the exact same implementation
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 2, 2021

📌 Commit 0e71283 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2021
@bors
Copy link
Contributor

bors commented Jun 2, 2021

⌛ Testing commit 0e71283 with merge dbe459d...

@bors
Copy link
Contributor

bors commented Jun 2, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing dbe459d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2021
@bors bors merged commit dbe459d into rust-lang:master Jun 2, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 2, 2021
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #85904!

Tested on commit dbe459d.
Direct link to PR: #85904

💔 miri on windows: test-pass → build-fail (cc @eddyb @RalfJung @oli-obk).
💔 miri on linux: test-pass → build-fail (cc @eddyb @RalfJung @oli-obk).

@rust-highfive rust-highfive mentioned this pull request Jun 2, 2021
Closed
rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 2, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#85904!
5a0f084 
Tested on commit rust-lang/rust@dbe459d.
Direct link to PR: <rust-lang/rust#85904>

💔 miri on windows: test-pass → build-fail (cc @eddyb @RalfJung @oli-obk).
💔 miri on linux: test-pass → build-fail (cc @eddyb @RalfJung @oli-obk).
@bors bors mentioned this pull request Jun 2, 2021
Merged
@ghost ghost mentioned this pull request Jun 3, 2021
Merged
bors added a commit to rust-lang/miri that referenced this pull request Jun 3, 2021
@bors
Auto merge of #1822 - hyd-dev:rustup, r=RalfJung
5dde0fe 
`original_crate_name` -> `crate_name`

`original_crate_name` was removed in rust-lang/rust#85904, and according to that PR, it "had the exact same implementation" as `crate_name`.

cc rust-lang/rust#85946
@cjgillot cjgillot deleted the one-name branch June 3, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cjgillot @rust-highfive @rust-timer @bors @petrochenkov @rust-log-analyzer @rustbot