Fix incorrect comment on abort_internal #86760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrong in several ways: 1. abort() still calls signal handlers 2. abort() no longer flushes streams (since glibc 2.27) Rather than trying to keep it up-to-date with the man page, it now just says "behaves the same as libc's abort".
jyn514
added
C-cleanup
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @m-ou-se |
|
#85377 also modifies this documentation. Do those changes suffice? |
m-ou-se
added
S-waiting-on-author
|
Hmm, well, it seems unfortunate that it keeps the whole history of libc's abort in the docs (which means they can get out of date), but otherwise the comment is a lot more helpful than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was wrong in several ways:
Rather than trying to keep it up-to-date with the man page, it now just says
"behaves the same as libc's abort".
This would have saved me quite a lot of time earlier today debugging.
cc #81895, #40230