Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] Hashbrown performance after Hashbrown PR #277 #87193

Closed
wants to merge 4 commits into from
Closed

[do not merge] Hashbrown performance after Hashbrown PR #277 #87193

wants to merge 4 commits into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jul 16, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2021
@Amanieu
Copy link
Member

Amanieu commented Jul 16, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2021
@bors
Copy link
Contributor

bors commented Jul 16, 2021

⌛ Trying commit 35105f781ec4d07e86ec4700bd83262992109078 with merge 9e0bddae0e3963ad4e1059a2fbc67b8f924065f2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 16, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2021
@Amanieu
Copy link
Member

Amanieu commented Jul 16, 2021

@bors try @rust-timer queue

@bors
Copy link
Contributor

bors commented Jul 16, 2021

⌛ Trying commit 082c914c026a163527859322146c6e2424c94ad3 with merge cbce48a16e4e575ed3fd942ad01f1f6731fd8fa0...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 16, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Jul 16, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jul 16, 2021

⌛ Trying commit f7d16ffd7c6ab1a9188fe085cb9937986688eebd with merge 532fc783a82edd5e8503640b96eeb4ad58dec438...

@bors
Copy link
Contributor

bors commented Jul 16, 2021

☀️ Try build successful - checks-actions
Build commit: 532fc783a82edd5e8503640b96eeb4ad58dec438 (532fc783a82edd5e8503640b96eeb4ad58dec438)

@rust-timer
Copy link
Collaborator

Queued 532fc783a82edd5e8503640b96eeb4ad58dec438 with parent c49895d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (532fc783a82edd5e8503640b96eeb4ad58dec438): comparison url.

Summary: This change led to significant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -10.5% on incr-patched: println builds of webrender-opt)
  • Moderate regression in instruction counts (up to 2.2% on incr-full builds of cranelift-codegen-opt)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 17, 2021
@Zoxc
Copy link
Contributor Author

Zoxc commented Jul 17, 2021

Before hashbrown PR vs after

@Zoxc Zoxc closed this Jul 17, 2021
@Zoxc Zoxc reopened this Jul 22, 2021
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2021
@bors
Copy link
Contributor

bors commented Jul 22, 2021

⌛ Trying commit 6b180eda54d37979a7ea1fe7665df6de426570ab with merge e3d53a8dda3f4013ee67323592b615c981b50816...

@bors
Copy link
Contributor

bors commented Jul 22, 2021

☀️ Try build successful - checks-actions
Build commit: e3d53a8dda3f4013ee67323592b615c981b50816 (e3d53a8dda3f4013ee67323592b615c981b50816)

@rust-timer
Copy link
Collaborator

Queued e3d53a8dda3f4013ee67323592b615c981b50816 with parent e742158, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e3d53a8dda3f4013ee67323592b615c981b50816): comparison url.

Summary: This change led to significant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -10.9% on incr-patched: println builds of webrender-opt)
  • Very large regression in instruction counts (up to 11.7% on full builds of cranelift-codegen-opt)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 23, 2021
@Zoxc Zoxc closed this Jul 23, 2021
@Zoxc Zoxc reopened this Jul 26, 2021
@Amanieu
Copy link
Member

Amanieu commented Jul 26, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 26, 2021
@bors
Copy link
Contributor

bors commented Jul 26, 2021

⌛ Trying commit c6d30cd with merge 6ebaa581fcddde8735fcb573a63a73429b7ebfe7...

@bors
Copy link
Contributor

bors commented Jul 26, 2021

☀️ Try build successful - checks-actions
Build commit: 6ebaa581fcddde8735fcb573a63a73429b7ebfe7 (6ebaa581fcddde8735fcb573a63a73429b7ebfe7)

@rust-timer
Copy link
Collaborator

Queued 6ebaa581fcddde8735fcb573a63a73429b7ebfe7 with parent 9cf1944, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6ebaa581fcddde8735fcb573a63a73429b7ebfe7): comparison url.

Summary: This change led to significant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -11.0% on incr-patched: println builds of webrender-opt)
  • Very large regression in instruction counts (up to 11.8% on full builds of cranelift-codegen-opt)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 26, 2021
@crlf0710 crlf0710 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2021
@crlf0710 crlf0710 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Sep 10, 2021
@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 14, 2021
@Zoxc Zoxc closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
perf-regression Performance regression. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Zoxc @Amanieu @rust-timer @bors @rust-log-analyzer @crlf0710 @apiraino @rust-highfive @rustbot