Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] Testing CI: Verify commits in beta are in stable. #87597

Closed

Conversation

yaymukund
Copy link
Contributor

Note: This is not to be merged or reviewed.

This PR exists to test the CI check I've written to address #74721

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2021
@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 3b1a639 to 37c92d6 Compare July 29, 2021 17:29
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 37c92d6 to 1252b3f Compare July 29, 2021 17:42
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 1252b3f to 5ccae75 Compare July 29, 2021 17:46
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 5ccae75 to 41f45ea Compare July 29, 2021 17:54
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 41f45ea to 624dae8 Compare July 29, 2021 18:06
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 624dae8 to 06f4549 Compare July 29, 2021 18:28
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2021
@Mark-Simulacrum Mark-Simulacrum removed their assignment Aug 2, 2021
@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 06f4549 to 923c945 Compare August 8, 2021 18:04
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 923c945 to b49cb9b Compare August 8, 2021 18:14
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from b49cb9b to 50aef19 Compare August 8, 2021 18:21
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 50aef19 to ff2dbdb Compare August 8, 2021 18:27
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from ff2dbdb to e12788d Compare August 8, 2021 18:31
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 4eea30b to aa2ed9c Compare August 9, 2021 00:14
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from aa2ed9c to 1a5b82c Compare August 9, 2021 00:20
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 1a5b82c to b344167 Compare August 9, 2021 00:37
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from b344167 to 870aee1 Compare August 19, 2021 21:22
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 870aee1 to e04bb61 Compare August 19, 2021 21:48
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from ab3d8ed to c1f820e Compare August 20, 2021 07:04
@rust-log-analyzer

This comment has been minimized.

@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from c1f820e to 4c4f30c Compare August 20, 2021 07:09
@rust-log-analyzer

This comment has been minimized.

Mukund Lakshman and others added 5 commits August 20, 2021 08:15
@yaymukund yaymukund force-pushed the test-verify-beta-stable-backports branch from 4c4f30c to 580dd2e Compare August 20, 2021 07:21
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Resolving deltas: 100% (1216323/1216323)
Resolving deltas: 100% (1216323/1216323), completed with 9611 local objects.
From https://github.com/rust-lang/rust
 * [new branch]              beta                   -> origin/beta
 * [new branch]              cranelift-rebase       -> origin/cranelift-rebase
 * [new branch]              issue-85533            -> origin/issue-85533
 * [new branch]              master                 -> origin/master
 * [new branch]              nellshamrell/fix-80658 -> origin/nellshamrell/fix-80658
 * [new branch]              revert-82057-cstr      -> origin/revert-82057-cstr
 * [new branch]              stable                 -> origin/stable
 * [new branch]              yeet-unused-substs     -> origin/yeet-unused-substs
✓ `3998e9860c73ae7a0dfdf9cf7f95483cd144d191` backports nothing
✓ `f36eb4df2091d5c684bb596cbef188716b5c17d6` backports `4a3e73643ab`
✓ `580dd2e27200bd8880a5f74e2949ec7170d62b9e` backports `fffa88eb27b451508a9f1abacf7ecbe9de9302f3`


All commits in \`HEAD\` are required to have a corresponding upstream commit.
It looks like the following commits:
    9a81cef29a40e654d1a5c94875a535a191993f48
    eda66493bff8a9b038f8935e4f060386c60738e3
    86cefca0e9d83b34c5bc986038d7667b9e6b257e
    739431df9531d3029806906157ac860d689dedee
    739431df9531d3029806906157ac860d689dedee
    f2ccd2a07e3f293671f3e9e64afeddcddd8d2d76

do not match any commits in `beta`. If this was intended, add the text
\`backport-of: <SHA of a commit already in master>\`
somewhere in the message of each of these commits.
Error: Found incorrectly marked commits.

The following commits:


    4d7aa5c940fc9934417debdbb599864e887d054c

have commit messages marked \`backport-of: <SHA>\`, but the SHA is not in
\`master\`.

✓ `3998e9860c73ae7a0dfdf9cf7f95483cd144d191` backports nothing
✓ `f36eb4df2091d5c684bb596cbef188716b5c17d6` backports `4a3e73643ab`


All commits in \`HEAD\` are required to have a corresponding upstream commit.
It looks like the following commits:
    9a81cef29a40e654d1a5c94875a535a191993f48
    eda66493bff8a9b038f8935e4f060386c60738e3
    86cefca0e9d83b34c5bc986038d7667b9e6b257e
    739431df9531d3029806906157ac860d689dedee
    739431df9531d3029806906157ac860d689dedee
    f2ccd2a07e3f293671f3e9e64afeddcddd8d2d76

do not match any commits in `master`. If this was intended, add the text
\`backport-of: <SHA of a commit already in master>\`
somewhere in the message of each of these commits.
Error: Found incorrectly marked commits.

The following commits:


    4d7aa5c940fc9934417debdbb599864e887d054c

have commit messages marked \`backport-of: <SHA>\`, but the SHA is not in
\`master\`.
##[error]Process completed with exit code 1.
Post job cleanup.

@yaymukund
Copy link
Contributor Author

#87604 shall soon merge ☺️

@yaymukund yaymukund closed this Aug 20, 2021
@yaymukund yaymukund deleted the test-verify-beta-stable-backports branch August 20, 2021 11:43
jackh726 added a commit to jackh726/rust that referenced this pull request Aug 22, 2021
…, r=Mark-Simulacrum

CI: Verify commits in beta & stable are in upstream branches.

Closes rust-lang#74721

I think this does the trick. rust-lang#87597 is an example of it failing as it should.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants