Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove git fetch from CI #87792

Merged
merged 1 commit into from Aug 15, 2021
Merged

Remove git fetch from CI #87792

merged 1 commit into from Aug 15, 2021

Conversation

GuillaumeGomez
Copy link
Member

#86623 added a call to git fetch, which is problematic for releases.

r? @pietroalbini

@GuillaumeGomez GuillaumeGomez added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Aug 5, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2021
@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review August 5, 2021 13:24
@GuillaumeGomez GuillaumeGomez added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2021
syvb
syvb reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@syvb syvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to include this commit, this error shouldn't be removed?

@GuillaumeGomez
Copy link
Member Author

This commit is here to make the CI fail. As long as the CI isn't failing, then the PR isn't working.

@GuillaumeGomez GuillaumeGomez force-pushed the ci-fetch branch 4 times, most recently from 8683162 to 450a097 Compare August 5, 2021 18:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

It's working. \o/ Removing the extra commit now...

@GuillaumeGomez
Copy link
Member Author

cc @Mark-Simulacrum btw

@GuillaumeGomez GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2021
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2021

📌 Commit c15bc2e has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2021
@bors
Copy link
Contributor

bors commented Aug 15, 2021

⌛ Testing commit c15bc2e with merge 909ab2635d564071e7525d8106a2934d6eecde3d...

@bors
Copy link
Contributor

bors commented Aug 15, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@GuillaumeGomez
Copy link
Member Author

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87792 - GuillaumeGomez:ci-fetch, r=pietroal…
8feadd7 
…bini

Remove git fetch from CI

rust-lang#86623 added a call to `git fetch`, which is problematic for releases.

r? `@pietroalbini`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87792 - GuillaumeGomez:ci-fetch, r=pietroal…
defc49a 
…bini

Remove git fetch from CI

rust-lang#86623 added a call to `git fetch`, which is problematic for releases.

r? ``@pietroalbini``
This was referenced Aug 15, 2021
Closed
Closed
@bors
Copy link
Contributor

bors commented Aug 15, 2021

⌛ Testing commit c15bc2e with merge c0490a2...

@bors
Copy link
Contributor

bors commented Aug 15, 2021

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing c0490a2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2021
@bors bors merged commit c0490a2 into rust-lang:master Aug 15, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 15, 2021
@GuillaumeGomez GuillaumeGomez deleted the ci-fetch branch August 15, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syvb syvb syvb left review comments

Assignees

@pietroalbini pietroalbini

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@GuillaumeGomez @rust-highfive @rust-log-analyzer @pietroalbini @bors @syvb @rustbot