Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace read_to_string with read_line in Stdin example #87820

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Aug 6, 2021

The current example results in infinitely reading from stdin, which can confuse newcomers trying to read from stdin.
(@RazMag encountered this while learning the language from the docs)

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2021
@rust-log-analyzer

This comment has been minimized.

@kennytm
Copy link
Member

kennytm commented Aug 9, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2021

📌 Commit 4763ef2 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
@bors
Copy link
Contributor

bors commented Aug 9, 2021

⌛ Testing commit 4763ef2 with merge eaf6f46...

@bors
Copy link
Contributor

bors commented Aug 9, 2021

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing eaf6f46 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2021
@bors bors merged commit eaf6f46 into rust-lang:master Aug 9, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 9, 2021
@elichai elichai deleted the patch-2 branch August 9, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants