Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate array::IntoIter::new. #88611

Merged
merged 5 commits into from
Dec 5, 2021
Merged

Deprecate array::IntoIter::new. #88611

merged 5 commits into from
Dec 5, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Sep 3, 2021

No description provided.

@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-edition-2021 Area: The 2021 edition labels Sep 3, 2021
@m-ou-se m-ou-se self-assigned this Sep 3, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2021
@m-ou-se m-ou-se mentioned this pull request Sep 3, 2021
Open
28 tasks
@m-ou-se
Copy link
Member Author

m-ou-se commented Sep 3, 2021

Since Rust 1.53, IntoIterator::into_iter([1, 2, 3]) works (on all editions), so array::IntoIter::new is no longer needed.

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Sep 3, 2021 •
edited by yaahc
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 3, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se m-ou-se added this to Not-really blockers (?) in 2021 Edition Blockers Sep 3, 2021
@m-ou-se m-ou-se moved this from Not-really blockers (?) to Post-stabilization cleanup in 2021 Edition Blockers Sep 3, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se m-ou-se force-pushed the array-into-iter-new-deprecate branch from 86b19bf to c5aa649 Compare September 3, 2021 10:52
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se m-ou-se force-pushed the array-into-iter-new-deprecate branch from c5aa649 to 11af9f0 Compare September 3, 2021 11:01
@bors
Copy link
Contributor

bors commented Sep 3, 2021

☔ The latest upstream changes (presumably #88618) made this pull request unmergeable. Please resolve the merge conflicts.

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Sep 4, 2021
@rfcbot
Copy link

rfcbot commented Sep 4, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Sep 4, 2021
@joshtriplett joshtriplett mentioned this pull request Sep 4, 2021
Merged
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Sep 14, 2021
@rfcbot
Copy link

rfcbot commented Sep 14, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 14, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 16, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2021
@joshtriplett
Copy link
Member

This looks ready to merge once the merge conflicts are fixed.

@camelid camelid removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2021
@camelid camelid added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 5, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2021
@m-ou-se m-ou-se force-pushed the array-into-iter-new-deprecate branch from 11af9f0 to eb3fc45 Compare December 4, 2021 18:40
@m-ou-se
Copy link
Member Author

m-ou-se commented Dec 5, 2021

@bors r=joshtriplett

@bors
Copy link
Contributor

bors commented Dec 5, 2021

📌 Commit 27d3935 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 5, 2021
@bors
Copy link
Contributor

bors commented Dec 5, 2021

⌛ Testing commit 27d3935 with merge 1597728...

@bors
Copy link
Contributor

bors commented Dec 5, 2021

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing 1597728 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 5, 2021
@bors bors merged commit 1597728 into rust-lang:master Dec 5, 2021
2021 Edition Blockers automation moved this from Post-stabilization cleanup to Completed items Dec 5, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 5, 2021
@m-ou-se m-ou-se deleted the array-into-iter-new-deprecate branch December 5, 2021 17:32
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1597728): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
A-edition-2021 Area: The 2021 edition disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
2021 Edition Blockers
  
Completed items
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

None yet