Rework HIR API to make invocations of the hir_crate query harder. #88880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 2067357c615db4c3df72eca28d54b3e8572255d2 with merge 61a27a20fa9db4b749e8bf81b59fc0bcb5d60587... |
|
☀️ Try build successful - checks-actions |
|
Queued 61a27a20fa9db4b749e8bf81b59fc0bcb5d60587 with parent 0212c70, future comparison URL. |
|
Finished benchmarking commit (61a27a20fa9db4b749e8bf81b59fc0bcb5d60587): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
oli-obk
requested changes
Sep 13, 2021
| @@ -23,7 +23,13 @@ LL | pub fn foo() {} | |||
|
|
|||
| error: requires `sized` lang_item | |||
|
|
|||
| error: aborting due to 3 previous errors | |||
| error: requires `sized` lang_item | |||
There was a problem hiding this comment.
Not very important (deduplicated for users anyway), but any idea why these are tripled?
There was a problem hiding this comment.
I'm also curious about this.
|
My first aim was to remove calls to |
|
Right, I got that, but it looks to me like the same amount of calls are still happening, but they are now hidden behind new functions. |
cjgillot
changed the title
This was referenced Sep 23, 2021
|
☔ The latest upstream changes (presumably #89328) made this pull request unmergeable. Please resolve the merge conflicts. |
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 77c3002 with merge cca895bdbd29df606af923faf3967edda3ee16ba... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Oct 1, 2021
|
Finished benchmarking commit (c02371c): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
|
Tagging as a perf regression. Our heuristics currently didn't flag this earlier, but it seems like many-assoc-items is indeed regressed by this PR. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 7, 2021
Rework HIR API to make invocations of the hir_crate query harder. `hir_crate` forces the recomputation of queries that depend on it. This PR aims at avoiding useless invocations of `hir_crate` by making dependent code go through `tcx.hir()`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2021
Index and hash HIR as part of lowering Part of rust-lang#88186 ~Based on rust-lang#88880 (see merge commit).~ Once HIR is lowered, it is later indexed by the `index_hir` query and hashed for `crate_hash`. This PR moves those post-processing steps to lowering itself. As a side objective, the HIR crate data structure is refactored as an `IndexVec<LocalDefId, Option<OwnerInfo<'hir>>>` where `OwnerInfo` stores all the relevant information for an HIR owner. r? `@michaelwoerister` cc `@petrochenkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hir_crateforces the recomputation of queries that depend on it.This PR aims at avoiding useless invocations of
hir_crateby making dependent code go throughtcx.hir().