Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make #[track_caller] actually do stuff in Steal::borrow #89237

Merged
merged 1 commit into from Sep 25, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Sep 24, 2021

makes this ICE message useful:
thread 'rustc' panicked at 'attempted to read from stolen value', /rustc/ac2d9fc509e36d1b32513744adf58c34bcc4f43c\compiler\rustc_data_structures\src\steal.rs:37:21

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2021
@eddyb
Copy link
Member

eddyb commented Sep 24, 2021

This might be sensitive for incremental:

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 24, 2021
@bors
Copy link
Contributor

bors commented Sep 24, 2021

⌛ Trying commit f1e71a5 with merge 26605d2c2c54440efef2a4936728fe5404196afa...

Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf comes out neutral

@bors
Copy link
Contributor

bors commented Sep 25, 2021

☀️ Try build successful - checks-actions
Build commit: 26605d2c2c54440efef2a4936728fe5404196afa (26605d2c2c54440efef2a4936728fe5404196afa)

@rust-timer
Copy link
Collaborator

Queued 26605d2c2c54440efef2a4936728fe5404196afa with parent 7342213, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (26605d2c2c54440efef2a4936728fe5404196afa): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 25, 2021
@workingjubilee
Copy link
Contributor

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Sep 25, 2021

📌 Commit f1e71a5 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2021
@klensy
Copy link
Contributor

klensy commented Sep 25, 2021

Better add test to track error message :-)

@bors
Copy link
Contributor

bors commented Sep 25, 2021

⌛ Testing commit f1e71a5 with merge 218a96c...

@bors
Copy link
Contributor

bors commented Sep 25, 2021

☀️ Test successful - checks-actions
Approved by: eddyb
Pushing 218a96c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2021
@bors bors merged commit 218a96c into rust-lang:master Sep 25, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 25, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (218a96c): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants