Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro_rules! duplication when reexported in the same module #89867

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Fix macro_rules! duplication when reexported in the same module #89867

merged 6 commits into from
Oct 19, 2021

Commits on Oct 13, 2021

  1. Deduplicate macro_rules! from module_exports when documenting them 

    This can append if within the same module a `#[macro_export] macro_rules!`
is declared but also a reexport of itself producing two export of the same
macro in the same module. In that case we only want to document it once.
    @Urgau
    Urgau committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    15c876d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Add regression test for rust-lang#89852

    @Urgau
    Urgau committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e252274 View commit details
    Browse the repository at this point in the history

  2. Oops, inverted condition, fix that

    @Urgau
    Urgau committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7d6cfb7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Apply documentation suggestions from code review 

    Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
    @Urgau @GuillaumeGomez
    Urgau and GuillaumeGomez committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    55fad29 View commit details
    Browse the repository at this point in the history

  2. Add equivalent test in src/test/rustdoc

    @Urgau
    Urgau committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    e259cc4 View commit details
    Browse the repository at this point in the history

  3. Rework the equivalent test to work with sidebar-items.js

    @Urgau
    Urgau committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    db5b64a View commit details
    Browse the repository at this point in the history