Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use clone3 when needed for pidfd #89930

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Only use clone3 when needed for pidfd #89930

merged 4 commits into from
Nov 11, 2021

Commits on Nov 5, 2021

  1. Only use clone3 when needed for pidfd 

    In rust-lang#89522 we learned that `clone3` is interacting poorly with Gentoo's
`sandbox` tool. We only need that for the unstable pidfd extensions, so
otherwise avoid that and use a normal `fork`.
    @cuviper
    cuviper committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    85b55ce View commit details
    Browse the repository at this point in the history

  2. Update another comment on fork vs. clone3

    @cuviper
    cuviper committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    fa2eee7 View commit details
    Browse the repository at this point in the history

  3. Also note tool expectations of fork vs clone3 

    Co-authored-by: Josh Triplett <josh@joshtriplett.org>
    @cuviper @joshtriplett
    cuviper and joshtriplett committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6edaaa6 View commit details
    Browse the repository at this point in the history

  4. Revert "Do not call getpid wrapper after fork in tests" 

    This reverts commit 12fbabd.

It was only needed because of using raw `clone3` instead of `fork`, but
we only do that now when a pidfd is requested.
    @cuviper
    cuviper committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    e96a0a8 View commit details
    Browse the repository at this point in the history