Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix const qualification when executed after promotion #90069

Merged
merged 2 commits into from
Oct 22, 2021

Commits on Oct 19, 2021

  1. Fix const qualification when executed after promotion

    The const qualification was so far performed before the promotion and
    the implementation assumed that it will never encounter a promoted.
    
    With `const_precise_live_drops` feature, checking for live drops is
    delayed until after drop elaboration, which in turn runs after
    promotion. so the assumption is no longer true. When evaluating
    `NeedsNonConstDrop` it is now possible to encounter promoteds.
    
    Use type base qualification for the promoted. It is a sound
    approximation in general, and in the specific case of promoteds and
    `NeedsNonConstDrop` it is precise.
    tmiasko committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    7581bae View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Configuration menu
    Copy the full SHA
    74c6636 View commit details
    Browse the repository at this point in the history