Change paths for `dist` command to match the components they generate #90684

jyn514 · 2021-11-08T04:39:25Z

Before, you could have the confusing situation where the command to
generate a component had no relation to the name of that component (e.g.
the rustc component was generated with src/librustc). This changes
the name to make them match up.

rust-highfive · 2021-11-08T04:39:28Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2021-11-08T12:19:49Z

I think we should pick one (components seem like a good idea, though I'm not sure it was a purposeful choice historically) and just have that, rather than trying to have multiple names.

jyn514 · 2021-11-08T13:52:42Z

My worry was that people would try to use the old names and get confused that they no longer work ... but I agree it does make more sense to just have them match the component, I'll do that.

Mark-Simulacrum · 2021-11-09T16:44:51Z

Can you check if there are any overlapping (i.e., same name) strings under dist now? I recall having to make a manual change a bit ago because the path(...) was the same for two dist steps or something like that.

jyn514 · 2021-11-09T17:00:31Z

@Mark-Simulacrum they look unique:

rg 'run\.path' src/bootstrap/dist.rs  | sed 's/.*"\(.*\)".*/\1/' | sort | uniq -c
      1 build-manifest
      1 cargo
      1 clippy
      1 extended
      1 llvm-tools
      1 miri
      1 reproducible-artifacts
      1 rls
      1 rust-analysis
      1 rust-analyzer
      1 rustc
      1 rustc-dev
      1 rustc-docs
      1 rustc-src
      1 rust-demangler
      1 rust-dev
      1 rust-docs
      1 rustfmt
      1 rust-mingw
      1 rust-src
      1 rust-std
      1 src/lldb_batchmode.py

Mark-Simulacrum · 2021-11-09T20:58:52Z

That last one looks like not the name of the produced component, but then I don't think build-manifest is either. So seems OK for now -- maybe a future PR can spend some time cleaning this up.

@bors r+

bors · 2021-11-09T20:58:53Z

📌 Commit 026a25b9a720942895374c0cdb4bbd095e5613ce has been approved by Mark-Simulacrum

jyn514 · 2021-11-11T00:34:01Z

@bors r=Mark-Simulacrum

bors · 2021-11-11T00:34:03Z

📌 Commit 3366327 has been approved by Mark-Simulacrum

Before, you could have the confusing situation where the command to generate a component had no relation to the name of that component (e.g. the `rustc` component was generated with `src/librustc`). This changes the name to make them match up.

Mark-Simulacrum · 2021-11-14T15:15:21Z

@bors r+

bors · 2021-11-14T15:15:23Z

📌 Commit d42a391 has been approved by Mark-Simulacrum

bors · 2021-11-14T18:37:03Z

⌛ Testing commit d42a391 with merge 8f778c82c4bcbcccb083345a6378c3debe817114...

bors · 2021-11-14T18:47:37Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-11-14T19:22:01Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] cfg_if test:false 0.046
   Compiling bitflags v1.2.1
[RUSTC-TIMING] cfg_if test:false 0.050
   Compiling typenum v1.12.0
Pass 'Module Summary Analysis' is not initialized.
Verify if there is a pass dependency cycle.
Required Passes:
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:
  - Pass misconfiguration (e.g.: missing macros)
  - Corruption of the global PassRegistry
 Error: Required pass not found! Possible causes:

Mark-Simulacrum · 2021-11-14T22:26:48Z

@bors retry cc #90812, I suspect, though hard to be sure

bors · 2021-11-15T03:19:04Z

⌛ Testing commit d42a391 with merge 4205481...

bors · 2021-11-15T06:19:26Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4205481 to master...

rust-timer · 2021-11-15T07:51:07Z

Finished benchmarking commit (4205481): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

Small improvement in instruction counts (up to -0.4% on incr-unchanged builds of regression-31157)
Moderate regression in instruction counts (up to 1.2% on incr-unchanged builds of html5ever)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Mark-Simulacrum · 2021-11-15T17:01:08Z

It looks like html5ever-check locally seems to improve, not regress, on this benchmark for me, though by a tiny instruction count -- 63,015 less instructions in early_resolve_ident_in_lexical_scope. I'm not sure what causes this but the inconsistency with actual results seems a little weird here; not clear exactly what could cause that. The wall-time for IncrUnchanged seems to be ~0.3 seconds. I'm seeing the same results for the incr-patched println test case, so it seems like a consistent improvement.

jyn514 · 2021-11-15T17:06:40Z

It's strange to me this would change performance at all, bootstrap isn't distributed period and the only other thing that changed in PR was some shell scripts.

Mark-Simulacrum · 2021-11-15T17:18:21Z

Well, at the very least, our artifacts currently contain the commit hash in a bunch of places as we remap paths to it. Maybe we should not do that -- so that a PR like this could be expected to produce identical binaries -- but we don't currently.

jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 8, 2021

rust-highfive assigned Mark-Simulacrum Nov 8, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2021

jyn514 added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2021

This comment has been minimized.

Sign in to view

jyn514 force-pushed the dist-aliases branch from 1ded73a to a4cf13d Compare November 8, 2021 04:43

jyn514 force-pushed the dist-aliases branch from a4cf13d to f79fd0a Compare November 8, 2021 13:58

jyn514 changed the title ~~Add aliases to dist command that match the components they generate~~ Change paths for dist command to match the components they generate Nov 8, 2021

jyn514 force-pushed the dist-aliases branch from f79fd0a to 026a25b Compare November 8, 2021 13:59

jyn514 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2021

jyn514 force-pushed the dist-aliases branch from 026a25b to 3366327 Compare November 11, 2021 00:31

jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2021

jyn514 force-pushed the dist-aliases branch from 3366327 to cf16405 Compare November 13, 2021 13:08

jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2021

jyn514 force-pushed the dist-aliases branch from cf16405 to 98c29ac Compare November 13, 2021 13:09

jyn514 force-pushed the dist-aliases branch from 98c29ac to d42a391 Compare November 13, 2021 13:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 14, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2021

bors merged commit 4205481 into rust-lang:master Nov 15, 2021

rustbot added this to the 1.58.0 milestone Nov 15, 2021

rustbot added the perf-regression Performance regression. label Nov 15, 2021

jyn514 deleted the dist-aliases branch November 15, 2021 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change paths for `dist` command to match the components they generate #90684

Change paths for `dist` command to match the components they generate #90684

jyn514 commented Nov 8, 2021 •

edited

rust-highfive commented Nov 8, 2021

This comment has been minimized.

Mark-Simulacrum commented Nov 8, 2021 •

edited

jyn514 commented Nov 8, 2021

Mark-Simulacrum commented Nov 9, 2021

jyn514 commented Nov 9, 2021

Mark-Simulacrum commented Nov 9, 2021

bors commented Nov 9, 2021

This comment has been minimized.

jyn514 commented Nov 11, 2021

bors commented Nov 11, 2021

Mark-Simulacrum commented Nov 14, 2021

bors commented Nov 14, 2021

bors commented Nov 14, 2021

bors commented Nov 14, 2021

rust-log-analyzer commented Nov 14, 2021

Mark-Simulacrum commented Nov 14, 2021

bors commented Nov 15, 2021

bors commented Nov 15, 2021

rust-timer commented Nov 15, 2021

Mark-Simulacrum commented Nov 15, 2021

jyn514 commented Nov 15, 2021

Mark-Simulacrum commented Nov 15, 2021

Change paths for dist command to match the components they generate #90684

Change paths for dist command to match the components they generate #90684

Conversation

jyn514 commented Nov 8, 2021 • edited

rust-highfive commented Nov 8, 2021

This comment has been minimized.

Mark-Simulacrum commented Nov 8, 2021 • edited

jyn514 commented Nov 8, 2021

Mark-Simulacrum commented Nov 9, 2021

jyn514 commented Nov 9, 2021

Mark-Simulacrum commented Nov 9, 2021

bors commented Nov 9, 2021

This comment has been minimized.

jyn514 commented Nov 11, 2021

bors commented Nov 11, 2021

Mark-Simulacrum commented Nov 14, 2021

bors commented Nov 14, 2021

bors commented Nov 14, 2021

bors commented Nov 14, 2021

rust-log-analyzer commented Nov 14, 2021

Mark-Simulacrum commented Nov 14, 2021

bors commented Nov 15, 2021

bors commented Nov 15, 2021

rust-timer commented Nov 15, 2021

Mark-Simulacrum commented Nov 15, 2021

jyn514 commented Nov 15, 2021

Mark-Simulacrum commented Nov 15, 2021

Change paths for `dist` command to match the components they generate #90684

Change paths for `dist` command to match the components they generate #90684

jyn514 commented Nov 8, 2021 •

edited

Mark-Simulacrum commented Nov 8, 2021 •

edited