Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.57.0 release notes #90832

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Add 1.57.0 release notes #90832

merged 1 commit into from
Nov 29, 2021

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Nov 12, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2021
@cuviper
Copy link
Member Author

cuviper commented Nov 12, 2021

cc @rust-lang/release

ehuss
ehuss reviewed Nov 13, 2021
View reviewed changes
RELEASES.md Show resolved Hide resolved
@joshtriplett
Copy link
Member

The release notes should also include all the must_use additions that were included in 1.57. (Some of them didn't make the cutoff, but many did.)

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Nov 16, 2021 •
edited
Loading

The release notes already have - [Many more functions are marked #[must_use]][89692], which IMO is maybe enough? It's not clear how much benefit we derive from listing the (long) list of functions.

@joshtriplett
Copy link
Member

@Mark-Simulacrum Fair enough; it probably doesn't add much value.

Might help to expand on what this means for people in practice, though; I'll add a structured suggestion.

joshtriplett
joshtriplett reviewed Nov 16, 2021
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
Mark-Simulacrum
Mark-Simulacrum reviewed Nov 20, 2021
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid camelid added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Nov 25, 2021
@Mark-Simulacrum Mark-Simulacrum marked this pull request as ready for review November 26, 2021 20:08
@Mark-Simulacrum
Copy link
Member

Removed new PM and squashed commits, will r+ once CI passes (previous failure looked spurious to me).

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup p=1

@bors
Copy link
Contributor

bors commented Nov 28, 2021

📌 Commit 4c3699f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 28, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2021
@bors
Auto merge of rust-lang#91338 - matthiaskrgr:rollup-46ry8wi, r=matthi…
a19e748 
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90131 (Fix a format_args span to be expansion)
 - rust-lang#90832 (Add 1.57.0 release notes)
 - rust-lang#90833 (Emit LLVM optimization remarks when enabled with `-Cremark`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ef0bcf into rust-lang:master Nov 29, 2021
@rustbot rustbot added this to the 1.59.0 milestone Nov 29, 2021
@cuviper cuviper deleted the relnotes-1.57.0 branch December 8, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@joshtriplett joshtriplett joshtriplett left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cuviper @rust-highfive @joshtriplett @Mark-Simulacrum @rust-log-analyzer @bors @ehuss @camelid @rustbot