-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #91090
Rollup of 4 pull requests #91090
Commits on Oct 10, 2021
-
Mark
Arc::from_inner
/Rc::from_inner
as unsafeWhile it's an internal function, it is easy to create invalid Arc/Rcs to a dangling pointer with it. Fixes rust-lang#89740
Configuration menu - View commit details
-
Copy full SHA for 2e2c38e - Browse repository at this point
Copy the full SHA 2e2c38eView commit details
Commits on Nov 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8dc8e72 - Browse repository at this point
Copy the full SHA 8dc8e72View commit details
Commits on Nov 20, 2021
-
Revert "require full validity when determining the discriminant of a …
…value" This reverts commit 0a2b7d7, reversing changes made to 47c1bd1. This caused several unforeseen problems: - rust-lang#91029 - rust-lang#89764 (comment)
Configuration menu - View commit details
-
Copy full SHA for 70d418c - Browse repository at this point
Copy the full SHA 70d418cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33c443d - Browse repository at this point
Copy the full SHA 33c443dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f625b7 - Browse repository at this point
Copy the full SHA 1f625b7View commit details -
Rollup merge of rust-lang#89741 - sdroege:arc-rc-from-inner-unsafe, r…
…=Mark-Simulacrum Mark `Arc::from_inner` / `Rc::from_inner` as unsafe While it's an internal function, it is easy to create invalid Arc/Rcs to a dangling pointer with it. Fixes rust-lang#89740
Configuration menu - View commit details
-
Copy full SHA for 85e2943 - Browse repository at this point
Copy the full SHA 85e2943View commit details -
Rollup merge of rust-lang#91018 - est31:let_else, r=matthewjasper
Adopt let_else in more places in rustc_mir_build Helps avoid rightward drift. followup of rust-lang#89933
Configuration menu - View commit details
-
Copy full SHA for 770f0b2 - Browse repository at this point
Copy the full SHA 770f0b2View commit details -
Rollup merge of rust-lang#91022 - compiler-errors:modulo_infer, r=est…
…ebank Suggest `await` in more situations where infer types are involved Currently we use `TyS::same_type` in diagnostics that suggest adding `.await` to opaque future types. This change makes the suggestion slightly more general, when we're comparing types like `Result<T, E>` and `Result<_, _>` which happens sometimes in places like `match` patterns or `let` statements with partially-elaborated types. ---- Question: 1. Is this change worthwhile? Totally fine if it doesn't make sense adding. 2. Should `same_type_modulo_infer` live in `rustc_infer::infer::error_reporting` or alongside the other method in `rustc_middle::ty::util`? 3. Should we generalize this change? I wanted to change all usages, but I don't want erroneous suggestions when adding `.field_name`...
Configuration menu - View commit details
-
Copy full SHA for b41214f - Browse repository at this point
Copy the full SHA b41214fView commit details -
Rollup merge of rust-lang#91088 - RalfJung:revert, r=oli-obk
Revert "require full validity when determining the discriminant of a value" This reverts commit 0a2b7d7, reversing changes made to 47c1bd1. This caused several unforeseen problems: - rust-lang#91029 - rust-lang#89764 (comment) So I think it's best to revert for now while we keep discussing the MIR semantics of getting a discriminant. r? `@oli-obk`
Configuration menu - View commit details
-
Copy full SHA for 34615eb - Browse repository at this point
Copy the full SHA 34615ebView commit details