Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mir-opt refactor #91279

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Small mir-opt refactor #91279

merged 1 commit into from
Dec 6, 2021

Conversation

scottmcm
Copy link
Member

Hopefully-non-controversial changes from some not-ready-yet work that I'd figured I'd submit on their own.

Hopefully-non-controversial changes from some not-ready-yet work that I'd figured I'd submit on their own.
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 27, 2021
@michaelwoerister
Copy link
Member

r? rust-lang/mir-opt

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 1, 2021
@nagisa
Copy link
Member

nagisa commented Dec 5, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2021

📌 Commit b215a32 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2021
@bors
Copy link
Contributor

bors commented Dec 5, 2021

⌛ Testing commit b215a32 with merge ecb65b0e170fc5275870c9d0fba7267a57cf35e5...

@bors
Copy link
Contributor

bors commented Dec 6, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing ecb65b0e170fc5275870c9d0fba7267a57cf35e5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 6, 2021
@bors
Copy link
Contributor

bors commented Dec 6, 2021

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@scottmcm
Copy link
Member Author

scottmcm commented Dec 6, 2021

Well, this passed, so might as well just put it in a
@bors rollup

but it probably also needs a
@bors retry

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ecb65b0e170fc5275870c9d0fba7267a57cf35e5): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@bors
Copy link
Contributor

bors commented Dec 6, 2021

⌛ Testing commit b215a32 with merge 0fb1c37...

@bors
Copy link
Contributor

bors commented Dec 6, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 0fb1c37 to master...

@bors bors merged commit 0fb1c37 into rust-lang:master Dec 6, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 6, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0fb1c37): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants