Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf only] Try to disable deferred inlining #91703

Closed
wants to merge 1 commit into from

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 9, 2021

Just to see what the perf effect is...

r? @ghost

@nikic
Copy link
Contributor Author

nikic commented Dec 9, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 9, 2021
@bors
Copy link
Contributor

bors commented Dec 9, 2021

⌛ Trying commit 453771a with merge 07378cd9e76010238f64ea03d1219774eb60510d...

@bors
Copy link
Contributor

bors commented Dec 9, 2021

☀️ Try build successful - checks-actions
Build commit: 07378cd9e76010238f64ea03d1219774eb60510d (07378cd9e76010238f64ea03d1219774eb60510d)

@rust-timer
Copy link
Collaborator

Queued 07378cd9e76010238f64ea03d1219774eb60510d with parent 3b263ce, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (07378cd9e76010238f64ea03d1219774eb60510d): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -8.4% on incr-patched: println builds of regression-31157)
  • Large regression in instruction counts (up to 2.4% on incr-full builds of deeply-nested)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 9, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022
@camelid
Copy link
Member

camelid commented Jan 23, 2022

I'm going to close this since AIUI, it was just a perf test. Please re-open if that's not the case.

@camelid camelid closed this Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants