Rollup of 6 pull requests #92624
Closed
Rollup of 6 pull requests #92624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream LLVM change 9290ccc migrated attribute removal to use AttributeMask instead of AttrBuilder, so we need to follow suit here.
A missing break statement lead to an infinite loop in bootstrap.py.
Avoids some extra conversions. Spotted by nikic during review.
Import `SimplifiedType` more
Rename `CStore::item_attrs` -> `CStore::item_attrs_untracked` top follow conventions
By avoiding formatting and allocations in the no-ident case, and by making the span mandatory if the ident exists. Use the optimized `opt_item_ident` to cleanup `fn each_child_of_item`
I think it makes the code easier to understand.
This is the next step in computing more "semantic" information during intra-doc link collection and then doing rendering all at the end.
This coalesces the checks into one place.
I had the epiphany that now that fragments are "semantic" -- rather than just strings -- they fill the role that used to be handled by the side channel. I think I may be able to get rid of the other uses of the side channel using this technique too.
Hooray! It was no longer used, so it can just be deleted.
This allows eliminating branches in the code where a user-written fragment is impossible.
return the correct type for closures in `type_of` A bit unhappy about the way `typeck::check_crate` works rn. Would have preferred to not change `CollectItemTypesVisitor` in this way. r? `@nikomatsakis`
RustWrapper: adapt to new AttributeMask API Upstream LLVM change 9290ccc migrated attribute removal to use AttributeMask instead of AttrBuilder, so we need to follow suit here. r? `@nagisa` cc `@nikic`
…lacrum Break the loop A missing break statement lead to an infinite loop in bootstrap.py. I also added a short sleep so it's not constantly running at 100%. But I can remove that if it's not wanted. Fixes rust-lang#76661
…anishearth rustdoc: Remove the intra-doc links side channel The side channel made the code much more complex and harder to understand. It was added as a temporary workaround in 0c99d80, but it's no longer necessary. The addition of `UrlFragment` in rust-lang#92088 was the key to getting rid of the side channel. The semantic information (rather than the strings that used to be used for fragments) that is now captured by `UrlFragment` is enough to obviate the side channel. An additional change had to be made to `UrlFragment` in this PR to make this possible: it now records `DefId`s rather than item names. This PR also consolidates the checks for anchor conflicts into one place. r? `@Manishearth`
rustc_metadata: Some minor cleanups and optimizations Mostly extracted from rust-lang#88679 (which is otherwise a rustdoc PR). r? `@cjgillot`
…t_struct, r=Mark-Simulacrum Remove unused `ExtendDefault` struct As noted in rust-lang#77850 (comment), this struct is no longer used.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=6 |
|
📌 Commit db056e9 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
type_of#91055 (return the correct type for closures intype_of)ExtendDefaultstruct #92620 (Remove unusedExtendDefaultstruct)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup