Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Yet more intra-doc links cleanup #92635

Merged
merged 10 commits into from
Jan 16, 2022
Merged

Commits on Jan 11, 2022

  1. Remove hack that is no longer necessary

    This hack was added in 6ab1f05.
    I don't know what change allowed removing the hack, but that commit
    added a test (which I presume covered the hack's behavior), and all
    tests are passing with this change. So, I think it should be good.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    49553bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e18b23b View commit details
    Browse the repository at this point in the history
  3. Enable ignored part of test

    Inherent associated types *are* supported, just unstable.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ca20d64 View commit details
    Browse the repository at this point in the history
  4. Add test for disambiguator mismatch with crate

    This currently calls `std` a "crate" in one part of the message and a
    "module" in another part. The next commits fix this so it says "crate"
    in both places.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    977a7ca View commit details
    Browse the repository at this point in the history
  5. Use Res instead of Disambiguator for resolved in report_mismatch

    This allows simplifying a lot of code. It also fixes a subtle bug,
    exemplified by the test output changes.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9acd813 View commit details
    Browse the repository at this point in the history
  6. Remove unnecessary conditional for suggesting disambiguator

    Now that `res` is used directly, it seems the conditional is
    unnecessary.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    591ec49 View commit details
    Browse the repository at this point in the history
  7. Update comment and make code clearer

    I'm still not sure why this hack works so seemingly well.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a5f09f7 View commit details
    Browse the repository at this point in the history
  8. Extract functions for two closures

    These closures were quite complex and part of a quite complex function.
    The fact that they are closures makes mistakes likely when refactoring.
    For example, earlier, I meant to use `resolved`, an argument of the
    closure, but I instead typed `res`, which captured a local variable and
    caused a subtle bug that led to a confusing test failure.
    
    Extracting them as functions makes the code easier to understand and
    refactor.
    camelid committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    895fa9c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    28d2353 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Fix broken link

    camelid committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    554c765 View commit details
    Browse the repository at this point in the history