-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Yet more intra-doc links cleanup #92635
Commits on Jan 11, 2022
-
Remove hack that is no longer necessary
This hack was added in 6ab1f05. I don't know what change allowed removing the hack, but that commit added a test (which I presume covered the hack's behavior), and all tests are passing with this change. So, I think it should be good.
Configuration menu - View commit details
-
Copy full SHA for 49553bb - Browse repository at this point
Copy the full SHA 49553bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e18b23b - Browse repository at this point
Copy the full SHA e18b23bView commit details -
Inherent associated types *are* supported, just unstable.
Configuration menu - View commit details
-
Copy full SHA for ca20d64 - Browse repository at this point
Copy the full SHA ca20d64View commit details -
Add test for disambiguator mismatch with crate
This currently calls `std` a "crate" in one part of the message and a "module" in another part. The next commits fix this so it says "crate" in both places.
Configuration menu - View commit details
-
Copy full SHA for 977a7ca - Browse repository at this point
Copy the full SHA 977a7caView commit details -
Use Res instead of Disambiguator for
resolved
inreport_mismatch
This allows simplifying a lot of code. It also fixes a subtle bug, exemplified by the test output changes.
Configuration menu - View commit details
-
Copy full SHA for 9acd813 - Browse repository at this point
Copy the full SHA 9acd813View commit details -
Remove unnecessary conditional for suggesting disambiguator
Now that `res` is used directly, it seems the conditional is unnecessary.
Configuration menu - View commit details
-
Copy full SHA for 591ec49 - Browse repository at this point
Copy the full SHA 591ec49View commit details -
Update comment and make code clearer
I'm still not sure why this hack works so seemingly well.
Configuration menu - View commit details
-
Copy full SHA for a5f09f7 - Browse repository at this point
Copy the full SHA a5f09f7View commit details -
Extract functions for two closures
These closures were quite complex and part of a quite complex function. The fact that they are closures makes mistakes likely when refactoring. For example, earlier, I meant to use `resolved`, an argument of the closure, but I instead typed `res`, which captured a local variable and caused a subtle bug that led to a confusing test failure. Extracting them as functions makes the code easier to understand and refactor.
Configuration menu - View commit details
-
Copy full SHA for 895fa9c - Browse repository at this point
Copy the full SHA 895fa9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d2353 - Browse repository at this point
Copy the full SHA 28d2353View commit details
Commits on Jan 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 554c765 - Browse repository at this point
Copy the full SHA 554c765View commit details