Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: add comment for people trying to figure out what "fabricate" is (NFC) #93042

Closed
wants to merge 1 commit into from
Closed

bootstrap: add comment for people trying to figure out what "fabricate" is (NFC) #93042

wants to merge 1 commit into from

Conversation

matthiaskrgr
Copy link
Member

Spent some time trying to figure out where the "fabricate" executable comes from, turns out the tool is actually named "rust-installer"

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2022
@Mark-Simulacrum
Copy link
Member

FWIW I'd be happy to accept a PR renaming the binary to rust-installer or something like that, which seems slightly preferable to this :)

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2022
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2022
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2022
This was referenced Mar 21, 2022
Closed
Merged
@Dylan-DPC
Copy link
Member

opened rust-lang/rust-installer#113 so this is not required

@Dylan-DPC Dylan-DPC closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthiaskrgr @rust-highfive @Mark-Simulacrum @Dylan-DPC @JohnCSimon