Refactor sidebar printing code #93830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new code is much simpler and easier to understand. In fact, the old code actually had a subtle bug where it excluded a few item types, including trait aliases, from the sidebar, even though they are rendered on the page itself! Now, all sections should show up in the sidebar.
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Feb 10, 2022
|
A bit more verbose but easier to follow so it's a nice improvement. Thanks! @bors: r+ rollup |
|
📌 Commit 504f3f0 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 10, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92670 (add kernel target for RustyHermit) - rust-lang#93756 (Support custom options for LLVM build) - rust-lang#93802 (fix oversight in the `min_const_generics` checks) - rust-lang#93808 (Remove first headings indent) - rust-lang#93824 (Stabilize cfg_target_has_atomic) - rust-lang#93830 (Refactor sidebar printing code) - rust-lang#93843 (kmc-solid: Fix wait queue manipulation errors in the `Condvar` implementation) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the refactoring parts of #92660, plus the trait aliases capitalization
consistency fix. I think this will be necessary for #92658.
r? @GuillaumeGomez