Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At opt-level=0, don't apply !nonnull or !range metadata to loads #94110

Closed

Conversation

erikdesjardins
Copy link
Contributor

This metadata is only used for optimization, so it shouldn't have any significant effect with the minimal LLVM pipeline at opt-level=0.

This may provide a small perf improvement for debug builds. (needs a perf run to confirm)

This metadata is only used for optimization, so it shouldn't have any
significant effect with the minimal LLVM pipeline at opt-level=0.

This should provide a small perf improvement for debug builds.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 18, 2022
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2022
@erikdesjardins
Copy link
Contributor Author

r? @tmiasko

@nikic
Copy link
Contributor

nikic commented Feb 18, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 18, 2022
@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Trying commit 03cc0cd with merge c0e91490a61b2cb72813bb297ed88232ed1d3e57...

@bors
Copy link
Contributor

bors commented Feb 18, 2022

☀️ Try build successful - checks-actions
Build commit: c0e91490a61b2cb72813bb297ed88232ed1d3e57 (c0e91490a61b2cb72813bb297ed88232ed1d3e57)

@rust-timer
Copy link
Collaborator

Queued c0e91490a61b2cb72813bb297ed88232ed1d3e57 with parent f838a42, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c0e91490a61b2cb72813bb297ed88232ed1d3e57): comparison url.

Summary: This benchmark run did not return any relevant results. 3 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 18, 2022
@erikdesjardins
Copy link
Contributor Author

Huh, I would've thought adding metadata was more expensive than adding enum attributes, but either it isn't or we don't apply these attributes to very many loads.

@erikdesjardins erikdesjardins deleted the debugloadattr branch February 18, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants