New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At opt-level=0, don't apply !nonnull or !range metadata to loads #94110
Conversation
This metadata is only used for optimization, so it shouldn't have any significant effect with the minimal LLVM pipeline at opt-level=0. This should provide a small perf improvement for debug builds.
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @tmiasko |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 03cc0cd with merge c0e91490a61b2cb72813bb297ed88232ed1d3e57... |
☀️ Try build successful - checks-actions |
Queued c0e91490a61b2cb72813bb297ed88232ed1d3e57 with parent f838a42, future comparison URL. |
Finished benchmarking commit (c0e91490a61b2cb72813bb297ed88232ed1d3e57): comparison url. Summary: This benchmark run did not return any relevant results. 3 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
Huh, I would've thought adding metadata was more expensive than adding enum attributes, but either it isn't or we don't apply these attributes to very many loads. |
This metadata is only used for optimization, so it shouldn't have any significant effect with the minimal LLVM pipeline at opt-level=0.
This may provide a small perf improvement for debug builds. (needs a perf run to confirm)