Fix miniz_oxide types showing up in std docs #94122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
added
the
T-rustdoc
GuillaumeGomez
changed the title
|
@bors r+ rollup |
|
📌 Commit b78123c has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
…otriddle Fix miniz_oxide types showing up in std docs Fixes rust-lang#90526. Thanks to `@camelid,` I rediscovered `doc(masked)`, allowing us to prevent `miniz_oxide` type to show up in std docs. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
…otriddle Fix miniz_oxide types showing up in std docs Fixes rust-lang#90526. Thanks to ``@camelid,`` I rediscovered `doc(masked)`, allowing us to prevent `miniz_oxide` type to show up in std docs. r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
…otriddle Fix miniz_oxide types showing up in std docs Fixes rust-lang#90526. Thanks to ```@camelid,``` I rediscovered `doc(masked)`, allowing us to prevent `miniz_oxide` type to show up in std docs. r? ```@notriddle```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
…otriddle Fix miniz_oxide types showing up in std docs Fixes rust-lang#90526. Thanks to ````@camelid,```` I rediscovered `doc(masked)`, allowing us to prevent `miniz_oxide` type to show up in std docs. r? ````@notriddle````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
…otriddle Fix miniz_oxide types showing up in std docs Fixes rust-lang#90526. Thanks to `````@camelid,````` I rediscovered `doc(masked)`, allowing us to prevent `miniz_oxide` type to show up in std docs. r? `````@notriddle`````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
…otriddle Fix miniz_oxide types showing up in std docs Fixes rust-lang#90526. Thanks to ``````@camelid,`````` I rediscovered `doc(masked)`, allowing us to prevent `miniz_oxide` type to show up in std docs. r? ``````@notriddle``````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2022
…askrgr Rollup of 14 pull requests Successful merges: - rust-lang#93580 (Stabilize pin_static_ref.) - rust-lang#93639 (Release notes for 1.59) - rust-lang#93686 (core: Implement ASCII trim functions on byte slices) - rust-lang#94002 (rustdoc: Avoid duplicating macros in sidebar) - rust-lang#94019 (removing architecture requirements for RustyHermit) - rust-lang#94023 (adapt static-nobundle test to use llvm-nm) - rust-lang#94091 (Fix rustdoc const computed value) - rust-lang#94093 (Fix pretty printing of enums without variants) - rust-lang#94097 (Add module-level docs for `rustc_middle::query`) - rust-lang#94112 (Optimize char_try_from_u32) - rust-lang#94113 (document rustc_middle::mir::Field) - rust-lang#94122 (Fix miniz_oxide types showing up in std docs) - rust-lang#94142 (rustc_typeck: adopt let else in more places) - rust-lang#94146 (Adopt let else in more places) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Should we backport this to beta? |
GuillaumeGomez
added
the
beta-nominated
|
This isn't a recent regression AFAIK, and it's a pretty low-priority issue, so I don't see why it should be backported. |
|
Mostly for users comfort. If unneeded, we can just remove the label. |
|
I won't block a backport, but I think it's best to let this ride the trains normally. |
|
@GuillaumeGomez Sorry to ping, but ^^^. |
|
It seems like the rustdoc team has spoken so I'll remove the tag. :) |
GuillaumeGomez
removed
the
beta-nominated
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 21, 2022
…Amanieu Correctly handle miniz_oxide extern crate declaration Fixes rust-lang#94219. Follow-up of rust-lang#94122. The `miniz_oxide` dependency is optional and therefore should allow be "imported" when it makes sense. r? `@ivmarkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90526.
Thanks to @camelid, I rediscovered
doc(masked), allowing us to preventminiz_oxidetype to show up in std docs.r? @notriddle