Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] rustc: Reimplement native library overriding and reordering #94962

Closed
wants to merge 1 commit into from
Closed

[WIP] rustc: Reimplement native library overriding and reordering #94962

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Mar 15, 2022 •
edited
Loading

Addresses the question (1) from #93901 (comment)
Fixes #73319

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 15, 2022
@petrochenkov
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Mar 15, 2022

⌛ Trying commit 4a86dbc1dcf2785279192d0f5008aec9e59c6d18 with merge 87da459d6eb75fe961960f80dcd24262c179e6dd...

@petrochenkov petrochenkov added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Mar 15, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 15, 2022
@petrochenkov petrochenkov force-pushed the linkstrict branch 2 times, most recently from 098cdbd to 695e871 Compare March 15, 2022 17:53
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@petrochenkov
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Trying commit dfe3db37401841c9850da16434b5f515b812ea91 with merge 6d66c4bea9820f41640120ccb1436ec01146c5af...

@bors

This comment was marked as resolved.

Sign in to view
@petrochenkov petrochenkov force-pushed the linkstrict branch 2 times, most recently from ca53777 to 8ba4c88 Compare March 16, 2022 16:39
@petrochenkov
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Trying commit 8ba4c88095931b47be575651f1ea3325fb4f0cad with merge 8aaecdf5df68a6fbc126704e44d399ba2fe66bf2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 16, 2022

☀️ Try build successful - checks-actions
Build commit: 8aaecdf5df68a6fbc126704e44d399ba2fe66bf2 (8aaecdf5df68a6fbc126704e44d399ba2fe66bf2)

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 16, 2022

☀️ Try build successful - checks-actions
Build commit: 8aaecdf5df68a6fbc126704e44d399ba2fe66bf2 (8aaecdf5df68a6fbc126704e44d399ba2fe66bf2)

@petrochenkov
Copy link
Contributor Author

@craterbot run mode=build-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-94962 created and queued.
🤖 Automatically detected try build 8aaecdf5df68a6fbc126704e44d399ba2fe66bf2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 16, 2022
@bors
Copy link
Contributor

bors commented Apr 3, 2022

☀️ Try build successful - checks-actions
Build commit: 50d916704ac4277b848d5a2e664fbf78c2444fec (50d916704ac4277b848d5a2e664fbf78c2444fec)

@petrochenkov
Copy link
Contributor Author

@craterbot run mode=build-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-94962-1/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-94962-2 created and queued.
🤖 Automatically detected try build 50d916704ac4277b848d5a2e664fbf78c2444fec
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-94962-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-94962-2 is completed!
📊 5 regressed and 5 fixed (58 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 5, 2022
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2022
@petrochenkov petrochenkov mentioned this pull request Apr 25, 2022
Open
This was referenced May 9, 2022
Merged
Merged
@petrochenkov
Copy link
Contributor Author

Blocked on #96885.

@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2022
@bors
Auto merge of rust-lang#96885 - petrochenkov:linkstrict2, r=cjgillot,…
10b3a0d 
…luqmana

rustc: Stricter checking for #[link] attributes

A subset of rust-lang#94962 that doesn't touch library renaming/reordering/deduplication.

`#[link]` attributes are checked for all kinds of unexpected arguments inside them.
I also tried to make wording for these errors more consistent, that's why some existing errors are changed, including errors for command line `-l` options.
Spans are also made more precise where possible.
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels May 15, 2022
@bors

This comment was marked as resolved.

Sign in to view
@petrochenkov petrochenkov changed the title [WIP] rustc: Implement stricter checking for #[link] attributes [WIP] rustc: Reimplement native library overriding and reordering May 15, 2022
@bors
Copy link
Contributor

bors commented May 21, 2022

☔ The latest upstream changes (presumably #97239) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov petrochenkov mentioned this pull request May 23, 2022
Closed
@tay64 tay64 mentioned this pull request Oct 12, 2022
Open
@JohnCSimon
Copy link
Member

@petrochenkov
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Jan 29, 2023
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linked native libraries are sometimes deduplicated and sometimes not deduplicated
7 participants
@petrochenkov @bors @rust-log-analyzer @craterbot @mati865 @JohnCSimon @rustbot