remove find_use_placement #95194
Merged
remove find_use_placement #95194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @pnkfelix |
|
☔ The latest upstream changes (presumably #90204) made this pull request unmergeable. Please resolve the merge conflicts. |
A more robust solution to finding where to place use suggestions was added. The algorithm uses the AST to find the span for the suggestion so we pass this span down to the HIR during lowering and use it. Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
kckeiks
force-pushed
the
update-algo-in-find-use-placement
branch
from
38dfaf5
to
8c2353b
Compare
|
@bors r+ |
|
📌 Commit 8c2353b has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 14, 2022
…cement, r=pnkfelix remove find_use_placement A more robust solution to finding where to place use suggestions was added in rust-lang#94584. The algorithm uses the AST to find the span for the suggestion so we pass this span down to the HIR during lowering and use it instead of calling `find_use_placement` Fixes rust-lang#94941
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 15, 2022
…cement, r=pnkfelix remove find_use_placement A more robust solution to finding where to place use suggestions was added in rust-lang#94584. The algorithm uses the AST to find the span for the suggestion so we pass this span down to the HIR during lowering and use it instead of calling `find_use_placement` Fixes rust-lang#94941
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
…cement, r=pnkfelix remove find_use_placement A more robust solution to finding where to place use suggestions was added in rust-lang#94584. The algorithm uses the AST to find the span for the suggestion so we pass this span down to the HIR during lowering and use it instead of calling `find_use_placement` Fixes rust-lang#94941
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
…cement, r=pnkfelix remove find_use_placement A more robust solution to finding where to place use suggestions was added in rust-lang#94584. The algorithm uses the AST to find the span for the suggestion so we pass this span down to the HIR during lowering and use it instead of calling `find_use_placement` Fixes rust-lang#94941
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2022
Rollup of 11 pull requests Successful merges: - rust-lang#94457 (Stabilize `derive_default_enum`) - rust-lang#94461 (Create (unstable) 2024 edition) - rust-lang#94849 (Check var scope if it exist) - rust-lang#95194 (remove find_use_placement) - rust-lang#95749 (only downgrade selection Error -> Ambiguous if type error is in predicate) - rust-lang#96026 (couple of clippy::complexity fixes) - rust-lang#96027 (remove function parameters only used in recursion) - rust-lang#96034 ([test] Add test cases of untested functions for BTreeSet ) - rust-lang#96040 (Use u32 instead of i32 for futexes.) - rust-lang#96062 (docs: Update tests chapter for Termination stabilization) - rust-lang#96065 (Refactor: Use `format-args-capture` and remove unnecessary nested blocks in rustc_typeck) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more robust solution to finding where to place use suggestions was added in #94584.
The algorithm uses the AST to find the span for the suggestion so we pass this span
down to the HIR during lowering and use it instead of calling
find_use_placementFixes #94941