make windows compat_fn (crudely) work on Miri #95775

RalfJung · 2022-04-07T18:09:32Z

With #95469, Windows compat_fn! now has to be supported by Miri to even make stdout work. Unfortunately, it relies on some outside-of-Rust linker hacks (#[link_section = ".CRT$XCU"]) that are rather hard to make work in Miri. So I came up with this crude hack to make this stuff work in Miri regardless. It should come at no cost for regular executions, so I hope this is okay.

Cc #95627 @ChrisDenton

rust-highfive · 2022-04-07T18:09:36Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

ChrisDenton · 2022-04-07T18:35:42Z

For a hack this looks fine. Though maybe I should ultimately look into better ways of doing lazy imports that don't rely on linker shenanigans.

RalfJung · 2022-04-07T18:59:15Z

While at it I also fixed a Strict Provenance violation; this code has been round-tripping a function pointer through an integer.

Gankra · 2022-04-07T19:53:01Z

Oh I think I got a bit confused here because this is a muddy case of #95489, I think?

ChrisDenton · 2022-04-07T20:21:58Z

@bors r=ChrisDenton

bors · 2022-04-07T20:22:00Z

📌 Commit c599a4c has been approved by ChrisDenton

RalfJung · 2022-04-07T20:33:23Z

Oh I think I got a bit confused here because this is a muddy case of #95489, I think?

Yeah, it's a function that returns a function pointer as a type FARPROC = *mut c_void. But better to stay in pointer regime than go through integers. :)

@bors p=1
(to unblock Miri ASAP)

…isDenton make windows compat_fn (crudely) work on Miri With rust-lang#95469, Windows `compat_fn!` now has to be supported by Miri to even make stdout work. Unfortunately, it relies on some outside-of-Rust linker hacks (`#[link_section = ".CRT$XCU"]`) that are rather hard to make work in Miri. So I came up with this crude hack to make this stuff work in Miri regardless. It should come at no cost for regular executions, so I hope this is okay. Cc rust-lang#95627 `@ChrisDenton`

bors · 2022-04-08T02:17:49Z

⌛ Testing commit c599a4c with merge e16f44ed4c7ed8613eab77fe561e085fae95a2fa...

bors · 2022-04-08T02:55:30Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-04-08T02:58:36Z

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


Some tests failed in compiletest suite=ui-fulldeps mode=ui host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc
error: test run failed!
status: exit code: 101
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw64\bin;C:\hostedtoolcache\windows\Python\3.10.4\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.4\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.3\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.322-6\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.5\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui-fulldeps\\stdio-from\\a.exe"
stdout: none
--- stderr -------------------------------
I/O error: operation failed to complete synchronously
thread 'main' panicked at 'assertion failed: child2.wait()?.success()', D:\a\rust\rust\src/test\ui-fulldeps\stdio-from.rs:50:5
------------------------------------------




failures:
    [ui] src/test\ui-fulldeps\stdio-from.rs

test result: FAILED. 65 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 23.25s

Build completed unsuccessfully in 0:32:34
make: *** [Makefile:72: ci-subset-1] Error 1

RalfJung · 2022-04-08T03:15:41Z

Hm, that looks suspiciously like #95759 and not something caused by this PR, doesn't it?

ChrisDenton · 2022-04-08T04:21:18Z

It does.

@bors retry

bors · 2022-04-08T04:55:43Z

⌛ Testing commit c599a4c with merge c077ccf869dccf708e3a906e78a4e0500187b1a2...

bors · 2022-04-08T05:39:52Z

💔 Test failed - checks-actions

ChrisDenton · 2022-04-08T05:55:37Z

Hmm, same problem.

@bors retry

rust-log-analyzer · 2022-04-08T08:04:52Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] src/test\ui-fulldeps\stdio-from.rs stdout ----

error: test run failed!
status: exit code: 101
command: PATH="D:\a\rust\rust\build\i686-pc-windows-msvc\stage2\lib\rustlib\i686-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x86;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0-bootstrap-tools\i686-pc-windows-msvc\release\deps;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw32\bin;C:\hostedtoolcache\windows\Python\3.10.4\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.4\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.3\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.322-6\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.5\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\ui-fulldeps\\stdio-from\\a.exe"
stdout: none
--- stderr -------------------------------
I/O error: operation failed to complete synchronously
thread 'main' panicked at 'assertion failed: child2.wait()?.success()', D:\a\rust\rust\src/test\ui-fulldeps\stdio-from.rs:50:5
------------------------------------------




failures:
    [ui] src/test\ui-fulldeps\stdio-from.rs

test result: FAILED. 65 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 26.98s

Build completed unsuccessfully in 0:38:19
make: *** [Makefile:72: ci-subset-1] Error 1

bors · 2022-04-08T08:13:31Z

⌛ Testing commit c599a4c with merge 1a4b9a8...

bors · 2022-04-08T10:41:04Z

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 1a4b9a8 to master...

rust-timer · 2022-04-08T12:13:58Z

Finished benchmarking commit (1a4b9a8): comparison url.

Summary:

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: 🎉 relevant improvements found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	0	2	6	2
mean²	N/A	N/A	-0.4%	-1.1%	-0.4%
max	N/A	N/A	-0.4%	-1.2%	-0.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

rylev · 2022-04-08T12:36:35Z

Looks like this wasn't actually a performance improvement just a reversion to normal after a blip in the last run.

RalfJung · 2022-04-09T13:37:53Z

For a hack this looks fine. Though maybe I should ultimately look into better ways of doing lazy imports that don't rely on linker shenanigans.

That, or we should implement rust-lang/miri#450.

make windows compat_fn (crudely) work on Miri

fe85591

rust-highfive assigned kennytm Apr 7, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2022

RalfJung mentioned this pull request Apr 7, 2022

miri no longer builds after rust-lang/rust#95624 #95627

Closed

do not round-trip function pointer through integer

c599a4c

RalfJung force-pushed the miri-windows-compat branch from 528f885 to c599a4c Compare April 7, 2022 19:00

RalfJung mentioned this pull request Apr 7, 2022

Rustup rust-lang/miri#2055

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2022

Dylan-DPC mentioned this pull request Apr 7, 2022

Rollup of 6 pull requests #95789

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2022

compiler-errors mentioned this pull request Apr 8, 2022

Enforce well formedness for type alias impl trait's hidden type #95519

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2022

bors merged commit 1a4b9a8 into rust-lang:master Apr 8, 2022

rustbot added this to the 1.62.0 milestone Apr 8, 2022

RalfJung deleted the miri-windows-compat branch April 8, 2022 12:45

RalfJung mentioned this pull request Apr 9, 2022

Load weak dll imports on Windows rust-lang/miri#1707

Closed

RalfJung mentioned this pull request Jun 13, 2022

Fix compat_fn option method on miri #98042

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make windows compat_fn (crudely) work on Miri #95775

make windows compat_fn (crudely) work on Miri #95775

RalfJung commented Apr 7, 2022

rust-highfive commented Apr 7, 2022

ChrisDenton commented Apr 7, 2022

RalfJung commented Apr 7, 2022

Gankra commented Apr 7, 2022

ChrisDenton commented Apr 7, 2022

bors commented Apr 7, 2022

RalfJung commented Apr 7, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

rust-log-analyzer commented Apr 8, 2022

RalfJung commented Apr 8, 2022

ChrisDenton commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

ChrisDenton commented Apr 8, 2022 •

edited

Loading

rust-log-analyzer commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

rust-timer commented Apr 8, 2022

rylev commented Apr 8, 2022

RalfJung commented Apr 9, 2022

make windows compat_fn (crudely) work on Miri #95775

make windows compat_fn (crudely) work on Miri #95775

Conversation

RalfJung commented Apr 7, 2022

rust-highfive commented Apr 7, 2022

ChrisDenton commented Apr 7, 2022

RalfJung commented Apr 7, 2022

Gankra commented Apr 7, 2022

ChrisDenton commented Apr 7, 2022

bors commented Apr 7, 2022

RalfJung commented Apr 7, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

rust-log-analyzer commented Apr 8, 2022

RalfJung commented Apr 8, 2022

ChrisDenton commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

ChrisDenton commented Apr 8, 2022 • edited Loading

rust-log-analyzer commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

rust-timer commented Apr 8, 2022

Footnotes

rylev commented Apr 8, 2022

RalfJung commented Apr 9, 2022

ChrisDenton commented Apr 8, 2022 •

edited

Loading